sdc-server admin-ip fails to retrieve admin nic on CN aggr interfaces

[mguegan]

It seems that if a Compute Node is running with aggr interfaces (and nic_tag was setted correctly), sdc-server can't find the admin nic because nic_tags_provided is not present.

[root@headnode (brn0-32-212) ~]# sdc-server admin-ip 00000000-0000-0000-0000-0cc47ab2341c
Error: No admin nic found

Output of sdc-server nics :

[...]
  {
    "belongs_to_type": "server",
    "belongs_to_uuid": "00000000-0000-0000-0000-0cc47ab2341c",
    "mac": "0c:c4:7a:b2:34:1c",
    "owner_uuid": "930896af-bf8c-48d4-885c-6573a94b1853",
    "primary": false,
    "state": "provisioning",
    "ip": "10.1.0.58",
    "mtu": 1500,
    "netmask": "255.255.255.0",
    "nic_tag": "admin",
    "resolvers": [
      "10.1.0.14"
    ],
    "vlan_id": 0,
    "network_uuid": "51b5038d-6370-4239-a22e-51ba4c625bed"
  },
[...]

Same output but for a Compute Node without aggr interface :

[...]
  {
    "belongs_to_type": "server",
    "belongs_to_uuid": "00000000-0000-0000-0000-0cc47a524864",
    "mac": "0c:c4:7a:52:48:64",
    "owner_uuid": "930896af-bf8c-48d4-885c-6573a94b1853",
    "primary": false,
    "state": "provisioning",
    "ip": "10.1.0.43",
    "mtu": 1500,
    "netmask": "255.255.255.0",
    "nic_tag": "admin",
    "resolvers": [
      "10.1.0.14"
    ],
    "vlan_id": 0,
    "network_uuid": "51b5038d-6370-4239-a22e-51ba4c625bed",
    "nic_tags_provided": [
      "admin"
    ]
  }

[mguegan]

I just saw a job failed on the SDC operation portal about napi.update_aggrs, it seems to be related with the addition of the nic_tags_provided tag.

    {
      "result": "",
      "error": {
        "name": "Error",
        "message": "Error updating aggregations in NAPI"
      },
      "name": "napi.update_aggrs",
      "started_at": "2016-07-25T12:54:57.940Z",
      "finished_at": "2016-07-25T12:54:57.981Z"
    }

I'll try to investigate..

[mguegan]

Please ignore my previous comment : its not related.

Here is another output which indicates that the tag seems correctly set :

# napictl get-aggr 00000000-0000-0000-0000-0cc47ab2341c-aggr2
{
  "belongs_to_uuid": "00000000-0000-0000-0000-0cc47ab2341c",
  "id": "00000000-0000-0000-0000-0cc47ab2341c-aggr2",
  "lacp_mode": "off",
  "name": "aggr2",
  "macs": [
    "0c:c4:7a:b2:34:1c",
    "0c:c4:7a:b2:34:1e"
  ],
  "nic_tags_provided": [
    "admin"
  ]
}

But sdc-server is unable to find it with nics or admin-ip parameters.

[KrisShannon]

I'm also having this issue.

It also affects the usefulness of sdc-login as it uses sdc-server admin-ip (Sorry, this was actually related to a generic login to any VM script I based off of sdc-login)

I note that sdc-server list does include the correct admin IP in it's output.

[KrisShannon]

The underlying nic of the aggregate which is booted from already had the admin IP associated with it directly (I think from the initial setup before the aggregation was setup)

If I assign the admin nic_tag via the adminui to this underlying interface the sdc-server admin-ip command can then find this IP.

Although this hack works, I'm unsure about any other affects it may cause.

[KrisShannon]

It seems there was a fix for sdc-server list to show the correct admin IP (HEAD-2205 - sdc-server fails to list IPs for aggr links fixed in 0a239288)

Maybe the same kind of fix will need to be made to sdc-server admin-ip. That would require changing admin-ip to use sysinfo from a cnapi getServer call instead of the current napi listNics call.