Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input requiring conversion to LinkToolbar in CJK environment results in double input #1065

Open
1 task
Aoichaan0513 opened this issue Sep 10, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Aoichaan0513
Copy link

Describe the bug
This problem occurs mainly when using languages that require conversion, such as Japanese, Chinese, and Korean.
Specifically, when using the LinkToolbar to input text that needs to be converted, the confirmed text is double-entered.
This should be remedied by changing the conditional branch in this section as follows.

if (event.key === “Enter” && !event.isComposing) {

To Reproduce

2024-09-10.23.56.21.mov

Misc

  • Node version: 20.11.0
  • Package manager: Yarn 4.3.1
  • Browser: Google Chrome 128.0.6613.120
  • I'm a sponsor and would appreciate if you could look into this sooner than later 💖
@Aoichaan0513 Aoichaan0513 added the bug Something isn't working label Sep 10, 2024
@matthewlipski
Copy link
Collaborator

Thanks for reporting this! Since you already found the source of the problem and the solution, do you want to go ahead and make a PR for this? We should be able to pretty much merge it straight away

@Aoichaan0513
Copy link
Author

That invitation is greatly appreciated!
However, it has become very difficult for me to devote resources these days, so I hope I can leave it to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants