Skip to content

Invalid regular expression in Safari < 16.4 #1825

@gbasto

Description

@gbasto

Describe the bug
Lookbehind regular expressions are being used to bold and code markdown text (detectMarkdown.ts).
Lookbehind is only supported from 16.4 above (caniuse), making any page that uses BlockNote unable to be used by Safari browsers bellow 16.4.

To Reproduce
Open any page (example) with BlockNote v0.33.0 in a Safari prior 16.4 and you get a blank page with a console error:
Invalid regular expression: invalid group specifier name

Misc
This was also an issue in Tiptap before, fixed in the meantime.
The issue #1760 is related with this, but it was misunderstood that the problem was related with named capture groups. The error is related with lookbehinds but Safari < 16.4 misinterprets them with a named capture groups hence the error message.

  • Node version:
  • Package manager:
  • Browser: Safari < 16.4
  • I'm a sponsor and would appreciate if you could look into this sooner than later 💖

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions