Skip to content

Commit 5de223f

Browse files
stopcoderGerrit Code Review
authored andcommitted
Merge "[INTERNAL] table/qunit/Scrolling: deprecate test with apiVersion: 1"
2 parents 3dc1819 + 319a8f2 commit 5de223f

File tree

1 file changed

+13
-3
lines changed

1 file changed

+13
-3
lines changed

src/sap.ui.table/test/sap/ui/table/qunit/extensions/Scrolling.qunit.js

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,6 @@ sap.ui.define([
165165
const oTable = this.oTable;
166166
const oScrollExtension = oTable._getScrollExtension();
167167
let oVSb = oScrollExtension.getVerticalScrollbar();
168-
const iOriginalApiVersion = TableRenderer.apiVersion;
169168

170169
assert.ok(oVSb.offsetWidth > 0 && oVSb.offsetHeight > 0, "Table content does not fit height -> Vertical scrollbar is visible");
171170

@@ -174,9 +173,20 @@ sap.ui.define([
174173
return oTable.qunit.whenRenderingFinished().then(function() {
175174
oVSb = oScrollExtension.getVerticalScrollbar();
176175
assert.ok(oVSb.offsetWidth === 0 && oVSb.offsetHeight === 0, "Table content fits height -> Vertical scrollbar is not visible");
176+
});
177+
});
177178

178-
}).then(function() {
179-
// BCP: 1970484410
179+
/** @deprecated As of version 1.120.0 */
180+
QUnit.test("Vertical scrollbar visibility with renderer API version 1", function(assert) {
181+
// BCP: 1970484410
182+
const oTable = this.oTable;
183+
const oScrollExtension = oTable._getScrollExtension();
184+
let oVSb = oScrollExtension.getVerticalScrollbar();
185+
const iOriginalApiVersion = TableRenderer.apiVersion;
186+
187+
oTable.getRowMode().setRowCount(6);
188+
189+
return oTable.qunit.whenRenderingFinished().then(function() {
180190
TableRenderer.apiVersion = 1;
181191
oTable.setModel(TableQUnitUtils.createJSONModelWithEmptyRows(7), "other");
182192
oTable.bindRows({

0 commit comments

Comments
 (0)