Skip to content

Commit 5fadde6

Browse files
committed
refactor metadata tests
1 parent 190945d commit 5fadde6

3 files changed

Lines changed: 20 additions & 14 deletions

File tree

src/face-detection-recognition/test/test_app_main.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ def get_expected_routes(self):
171171
"task_schema": f"/{APP_NAME}/bulkupload/task_schema",
172172
"run_task": f"/{APP_NAME}/bulkupload",
173173
"short_title": "Bulk Upload",
174-
"order": 3,
174+
"order": 0,
175175
},
176176
# {
177177
# "task_schema": f"/{APP_NAME}/multi_pipeline_bulkupload/task_schema",
@@ -189,7 +189,7 @@ def get_expected_routes(self):
189189
"task_schema": f"/{APP_NAME}/deletecollection/task_schema",
190190
"run_task": f"/{APP_NAME}/deletecollection",
191191
"short_title": "Delete Collection",
192-
"order": 4,
192+
"order": 2,
193193
},
194194
# {
195195
# "task_schema": f"/{APP_NAME}/listcollections/task_schema",

src/rb-lib/rb/lib/common_tests.py

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
from abc import ABC, abstractmethod
2+
import json
3+
import ast
24
from typing import List, Tuple
35
from rb.api.models import AppMetadata, TaskSchema
46
from typer.testing import CliRunner
@@ -67,6 +69,9 @@ def test_routes_command(self, caplog):
6769
assert any(
6870
route["short_title"] in message for message in caplog.messages
6971
)
72+
assert any(
73+
str(route["order"]) in message for message in caplog.messages
74+
)
7075

7176
def check_if_str_in_messages(self, str_to_check: str, messages: List[str]):
7277
"""
@@ -81,10 +86,14 @@ def test_metadata_command(self, caplog):
8186
self.cli_app, [f"/{self.app_name}/api/app_metadata"]
8287
)
8388
assert result.exit_code == 0
89+
for message in caplog.messages:
90+
out_data = json.loads(json.dumps(message))
91+
actual_metadata = ast.literal_eval(out_data)
92+
print("debug", actual_metadata.keys())
8493
for key, value in expected_metadata:
8594
print("debug", key, value)
86-
assert any(str(key) in message for message in caplog.messages)
87-
assert len(str(value)) > 0
95+
assert any(str(key) in k for k in actual_metadata.keys())
96+
assert len(json.dumps(value)) == len(json.dumps(actual_metadata[key]))
8897

8998
def test_schema_command(self, caplog):
9099
with caplog.at_level("INFO"):
@@ -112,9 +121,11 @@ def test_api_metadata(self):
112121
response = self.client.get(f"/{self.app_name}/api/app_metadata")
113122
assert response.status_code == 200
114123
body = response.json()
124+
actual_metadata = json.loads(json.dumps(body))
115125
expected_metadata = self.get_metadata().model_dump(mode="json")
116-
assert len(body) > 0
117-
assert len(expected_metadata) > 0
126+
for key in expected_metadata.keys():
127+
assert any(str(key) in k for k in actual_metadata.keys())
128+
assert len(expected_metadata[key]) == len(actual_metadata[key])
118129

119130
def test_api_task_schema(self):
120131
ml_services = self.get_all_ml_services()

src/ufdr-mounter/tests/test_main_ufdr_mounter.py

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from ufdr_mounter.ufdr_server import app as cli_app, APP_NAME, ufdr_task_schema
1+
from ufdr_mounter.ufdr_server import app as cli_app, APP_NAME, ufdr_task_schema, server
22
from rb.lib.common_tests import RBAppTest
33
from rb.api.models import AppMetadata, ResponseBody
44
from pathlib import Path
@@ -12,13 +12,8 @@ def setup_method(self):
1212
self.set_app(cli_app, APP_NAME)
1313

1414
def get_metadata(self):
15-
return AppMetadata(
16-
name="UFDR Mount Service",
17-
author="Sribatscha Maharana",
18-
version="1.0.0",
19-
info="Mounts a UFDR file using FUSE and returns status.",
20-
plugin_name=APP_NAME,
21-
)
15+
"""Return app metadata for testing"""
16+
return server._app_metadata
2217

2318
def get_all_ml_services(self):
2419
return [

0 commit comments

Comments
 (0)