Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EM-3355 Save API enhancements / Allowing Generators/Transporters/Brookers to set to scheduled/pending via services #1644

Open
e-manifest opened this issue Feb 7, 2025 · 0 comments

Comments

@e-manifest
Copy link
Contributor

This is enhancement is to align the Save API with the UI and the enhancements under EM-3155. Another ticket will be created to update Update and Patch Update.

When a Generator/Transporter/ or Broker submits a manifest via the Save Service with "status":"Scheduled” and the row for the “billed_facility_id“ in RCRA_EMAN_SITE_SETTINGS has ALLOW_OTHER_SITES_SCHEDULE=1, then the manifest is set to "status":"Scheduled"

When a Generator/Transporter/ or Broker submits a manifest via the Save Service with "status":"Scheduled" and the row for the “billed_facility_id“ in RCRA_EMAN_SITE_SETTINGS has ALLOW_OTHER_SITES_SCHEDULE=0, then the manifest is set to "status":"Pending" with the response warning:

{noformat} {
"field": "Emanifest.status",
"message": "Provided Status will be ignored. The Receiving Facility does not allow other sites to set manifests to scheduled. Emanifest will be assigned Pending status",
"value": "FullElectronic"
}{noformat}

I discovered an issue that needs to be fixed with this enhancement. Currently I can create a manifest as a generator/transporter/broker (GTB) via services and set it to scheduled which is not correct. GTBs can only set manifests to scheduled if the TSDF allows other sites to set manifests to scheduled which this ticket will resolve.

Further, any facility should be able to set manifests to Pending, however if I try to submit a manifest as pending I get the following warning and the manifest is set to scheduled (I do not want to relax our logic for pending to match the UI in this ticket):

{noformat} {
"field": "Emanifest.status",
"message": "Provided Status will be ignored. Emanifest will be assigned Scheduled status",
"value": "Pending"
}{noformat}

To recreate: You must use a user that does not have a TSDF on the account and is a site manager. See user scottdchristianRCRA612 for an example user.

Here are JSON examples

[^Hybrid-Generator.json]
[^FE-Generator.json]



Acceptance Criteria
(x) When a facility submits a manifest via the Save Service with "status":"Pending" then the manifest is set to "status":"Pending"

(x) When a Generator/Transporter/ or Broker submits a manifest via the Save Service with "status":"Scheduled" and RCRA_EMAN_SITE_SETTINGS.ALLOW_OTHER_SITES_SCHEDULE=1, then the manifest is set to "status":"Scheduled"

(x) When a Generator/Transporter/ or Broker submits a manifest via the Save Service with "status":"Scheduled" and RCRA_EMAN_SITE_SETTINGS.ALLOW_OTHER_SITES_SCHEDULE=0, then the manifest is set to "status":"Pending" with the response:

{noformat} {
"field": "Emanifest.status",
"message": "Provided Status will be ignored. The Receiving Facility does not allow other sites to set manifests to Scheduled. Emanifest will be assigned Pending status",
"value": "Scheduled"
}{noformat}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant