Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EM-3356 Update and PATCH Update API enhancements / Allowing Generators/Transporters/Brookers to set to scheduled/pending via services #1645

Open
e-manifest opened this issue Feb 7, 2025 · 0 comments

Comments

@e-manifest
Copy link
Contributor

This is enhancement is to align the Update and Update PATCH APIs with the UI and the enhancements under EM-3155. [https://rcrainfo.atlassian.net/browse/EM-3355|https://rcrainfo.atlassian.net/browse/EM-3355|smart-link] was created for the Save service.

This enhancement is only relevant to Unsigned manifests in the Pending Status that are being updated. We will continue to not allow manifests to be pulled back scheduled via services

When a Generator/Transporter/ or Broker submits "status":"Scheduled” to a "status":"Pending“ manifest via the Update Service and the row for the “billed_facility_id“ in RCRA_EMAN_SITE_SETTINGS has ALLOW_OTHER_SITES_SCHEDULE=1, then the manifest is set to "status":"Scheduled"

When a Generator/Transporter/ or Broker submits "status":"Scheduled” to a "status":"Pending“ manifest via the Update Service and the row for the “billed_facility_id“ in RCRA_EMAN_SITE_SETTINGS has ALLOW_OTHER_SITES_SCHEDULE=0, then the manifest remains in "status":"Pending" with the response warning:

{noformat} {
"field": "Emanifest.status",
"message": "Provided Status will be ignored. The Receiving Facility does not allow other sites to set manifests to scheduled. Emanifest will be assigned Pending status",
"value": "FullElectronic"
}{noformat}

I discovered an issue that needs to be fixed with this enhancement. If a Generator/Transporter/ or Broker trys to submit an update to manifest that is status":"Pending“ with status":"Pending“ I get the error below. If I am a Generator/Transporter/ or Broker is trying to update the other data in a Pending Manifest then they should be able to as long as they meet the other existing services business rules:

{noformat} "errors": [
{
"field": "Emanifest.status",
"message": "Invalid Field Format. One of the following values: 'Scheduled', 'InTransit','Received','ReadyForSignature', 'Signed', 'Rejected' is expected",
"value": "Pending"
}{noformat}

To recreate: You must use a user that does not have a TSDF on the account and is a site manager. See user scottdchristianRCRA612 for an example user.

Here are JSON examples (you will need to add the element: "manifestTrackingNumber" for example "manifestTrackingNumber":"100040649ELC",

[^Hybrid-Generator.json]
[^FE-Generator.json]



Acceptance Criteria
(x) When a facility submits a manifest via the Update Service or the Update Patch service to an unsigned manifest with "status":"Pending" then the manifest stays "status":"Pending"

(x) When a Generator/Transporter/ or Broker submits a manifest via the Update Service or the Update Patch service to an unsigned manifest with "status":"Scheduled" and RCRA_EMAN_SITE_SETTINGS.ALLOW_OTHER_SITES_SCHEDULE=1, then the manifest is set to "status":"Scheduled"

(x) When a Generator/Transporter/ or Broker submits a manifest via the Update Service or the Update Patch service to an unsigned manifest with "status":"Scheduled" and RCRA_EMAN_SITE_SETTINGS.ALLOW_OTHER_SITES_SCHEDULE=0, then the manifest is set to "status":"Pending" with the response:

{noformat} {
"field": "Emanifest.status",
"message": "Provided Status will be ignored. The Receiving Facility does not allow other sites to set manifests to Scheduled. Emanifest will be assigned Pending status",
"value": "Scheduled"
}{noformat}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant