Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static type hints #1298

Closed
headtr1ck opened this issue Dec 8, 2023 · 2 comments · Fixed by #1302
Closed

Add static type hints #1298

headtr1ck opened this issue Dec 8, 2023 · 2 comments · Fixed by #1302

Comments

@headtr1ck
Copy link
Contributor

Since static typing has come a long way in python, it would be nice if you could add static type hints to netCDF4.

There has already been some work done here: python/typeshed#9545

If you think that this support should be carried out externally (like in the linked typeshed issue), feel free to close this issue.

@jswhit
Copy link
Collaborator

jswhit commented Dec 12, 2023

there was some work done on this (#1279), but the OP closed the pull request.

@RandallPittmanOrSt
Copy link
Contributor

Hey, @headtr1ck, @jswhit, @Woefie, high five on getting the type stubs into 1.7.2! (ref #1279, #1302, and #1349)! Thanks especially to Lars and Michael for your initial work and Jeff and Michael for your meticulous reviews of my PR. It's been a pleasure to work with you on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants