Skip to content

Commit c9391ee

Browse files
committed
Address PR comments
1 parent 2cecdb0 commit c9391ee

4 files changed

Lines changed: 25 additions & 25 deletions

File tree

rest/python/client/flower_shop/simple_happy_path_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -795,7 +795,7 @@ def main() -> None:
795795
# Matches the structure expected by the server's updated complete_checkout
796796

797797
final_payload = {
798-
"payment_data": {
798+
"payment": {
799799
"id": "instr_my_card",
800800
"handler_id": target_handler,
801801
"handler_name": target_handler,

rest/python/server/routes/discovery_profile.json

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
{
22
"ucp": {
3-
"version": "2026-01-11",
3+
"version": "2026-01-23",
44
"services": {
55
"dev.ucp.shopping": [
66
{
7-
"version": "2026-01-11",
7+
"version": "2026-01-23",
88
"spec": "https://ucp.dev/specification/reference",
99
"transport": "rest",
1010
"endpoint": "{{ENDPOINT}}",
@@ -16,23 +16,23 @@
1616
"dev.ucp.shopping.checkout": [
1717
{
1818
"name": "dev.ucp.shopping.checkout",
19-
"version": "2026-01-11",
19+
"version": "2026-01-23",
2020
"spec": "https://ucp.dev/specification/checkout",
2121
"schema": "https://ucp.dev/schemas/shopping/checkout.json"
2222
}
2323
],
2424
"dev.ucp.shopping.order": [
2525
{
2626
"name": "dev.ucp.shopping.order",
27-
"version": "2026-01-11",
27+
"version": "2026-01-23",
2828
"spec": "https://ucp.dev/specification/order",
2929
"schema": "https://ucp.dev/schemas/shopping/order.json"
3030
}
3131
],
3232
"dev.ucp.shopping.discount": [
3333
{
3434
"name": "dev.ucp.shopping.discount",
35-
"version": "2026-01-11",
35+
"version": "2026-01-23",
3636
"spec": "https://ucp.dev/specification/discount",
3737
"schema": "https://ucp.dev/schemas/shopping/discount.json",
3838
"extends": "dev.ucp.shopping.checkout"
@@ -41,7 +41,7 @@
4141
"dev.ucp.shopping.fulfillment": [
4242
{
4343
"name": "dev.ucp.shopping.fulfillment",
44-
"version": "2026-01-11",
44+
"version": "2026-01-23",
4545
"spec": "https://ucp.dev/specification/fulfillment",
4646
"schema": "https://ucp.dev/schemas/shopping/fulfillment.json",
4747
"extends": "dev.ucp.shopping.checkout"
@@ -50,7 +50,7 @@
5050
"dev.ucp.shopping.buyer_consent": [
5151
{
5252
"name": "dev.ucp.shopping.buyer_consent",
53-
"version": "2026-01-11",
53+
"version": "2026-01-23",
5454
"spec": "https://ucp.dev/specification/buyer-consent",
5555
"schema": "https://ucp.dev/schemas/shopping/buyer_consent.json",
5656
"extends": "dev.ucp.shopping.checkout"
@@ -62,11 +62,11 @@
6262
{
6363
"id": "shop_pay",
6464
"name": "com.shopify.shop_pay",
65-
"version": "2026-01-11",
65+
"version": "2026-01-23",
6666
"spec": "https://shopify.dev/docs/agents/checkout/shop-pay-handler",
67-
"config_schema": "https://shopify.dev/ucp/shop-pay-handler/2026-01-11/config.json",
67+
"config_schema": "https://shopify.dev/ucp/shop-pay-handler/2026-01-23/config.json",
6868
"instrument_schemas": [
69-
"https://shopify.dev/ucp/shop-pay-handler/2026-01-11/instrument.json"
69+
"https://shopify.dev/ucp/shop-pay-handler/2026-01-23/instrument.json"
7070
],
7171
"config": {
7272
"shop_id": "{{SHOP_ID}}"
@@ -77,11 +77,11 @@
7777
{
7878
"id": "google_pay",
7979
"name": "com.google.pay",
80-
"version": "2026-01-11",
81-
"spec": "https://pay.google.com/gp/p/ucp/2026-01-11/",
82-
"config_schema": "https://pay.google.com/gp/p/ucp/2026-01-11/schemas/config.json",
80+
"version": "2026-01-23",
81+
"spec": "https://pay.google.com/gp/p/ucp/2026-01-23/",
82+
"config_schema": "https://pay.google.com/gp/p/ucp/2026-01-23/schemas/config.json",
8383
"instrument_schemas": [
84-
"https://pay.google.com/gp/p/ucp/2026-01-11/schemas/card_payment_instrument.json"
84+
"https://pay.google.com/gp/p/ucp/2026-01-23/schemas/card_payment_instrument.json"
8585
],
8686
"config": {
8787
"api_version": 2,
@@ -118,7 +118,7 @@
118118
{
119119
"id": "mock_payment_handler",
120120
"name": "mock_payment_handler",
121-
"version": "2026-01-11",
121+
"version": "2026-01-23",
122122
"spec": "https://ucp.dev/schemas/mock_payment_handler/spec",
123123
"config": {}
124124
}

rest/python/server/routes/ucp_implementation.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@
3333
from pydantic import BaseModel
3434
from pydantic import HttpUrl
3535
from services.checkout_service import CheckoutService
36-
from ucp_sdk.models.schemas.shopping.ap2_mandate import (
37-
Checkout as Ap2CompleteRequest,
36+
from ucp_sdk.models.schemas.shopping.checkout_complete_request import (
37+
CheckoutCompleteRequest,
3838
)
3939
from ucp_sdk.models.schemas.shopping.order import Order
4040
from ucp_sdk.models.schemas.shopping.order import PlatformSchema
@@ -214,7 +214,7 @@ async def complete_checkout(
214214
checkout_service: Annotated[
215215
CheckoutService, Depends(dependencies.get_checkout_service)
216216
],
217-
ap2: Annotated[Ap2CompleteRequest | None, Body()] = None,
217+
checkout_complete: Annotated[CheckoutCompleteRequest | None, Body()] = None,
218218
) -> dict[str, Any]:
219219
"""Complete Checkout Implementation."""
220220
del common_headers # Unused
@@ -225,7 +225,7 @@ async def complete_checkout(
225225
)
226226

227227
checkout_result = await checkout_service.complete_checkout(
228-
checkout_id, payment_req, risk_signals, idempotency_key, ap2=ap2
228+
checkout_id, payment_req, risk_signals, idempotency_key, checkout_complete=checkout_complete
229229
)
230230
return checkout_result.model_dump(mode="json", by_alias=True)
231231

rest/python/server/services/checkout_service.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,8 @@
6161
from ucp_sdk.models.schemas.ucp import UcpMetadata
6262
from ucp_sdk.models.schemas.ucp import Version
6363
from ucp_sdk.models.schemas.capability import ResponseSchema as Response
64-
from ucp_sdk.models.schemas.shopping.ap2_mandate import (
65-
Checkout as Ap2CompleteRequest,
64+
from ucp_sdk.models.schemas.shopping.checkout_complete_request import (
65+
CheckoutCompleteRequest,
6666
)
6767
from ucp_sdk.models.schemas.shopping.discount import Allocation
6868
from ucp_sdk.models.schemas.shopping.discount import AppliedDiscount
@@ -618,17 +618,17 @@ async def complete_checkout(
618618
payment: PaymentCreateRequest,
619619
risk_signals: dict[str, Any],
620620
idempotency_key: str,
621-
ap2: Ap2CompleteRequest | None = None,
621+
checkout_complete: CheckoutCompleteRequest | None = None,
622622
) -> Checkout:
623623
"""Complete a checkout session."""
624624
logger.info("Completing checkout session %s", checkout_id)
625625

626626
# Idempotency Check
627-
# Include risk_signals and ap2 in the hash
627+
# Include risk_signals and checkout_complete in the hash
628628
combined_data = {
629629
"payment": payment.model_dump(mode="json"),
630630
"risk_signals": risk_signals,
631-
"ap2": ap2.model_dump(mode="json") if ap2 else None,
631+
"checkout_complete": checkout_complete.model_dump(mode="json") if checkout_complete else None,
632632
}
633633
request_hash = self._compute_hash(combined_data)
634634

0 commit comments

Comments
 (0)