Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Tray icon image has excessively large dimensions #860

Open
3 tasks done
pdf opened this issue Sep 17, 2024 · 0 comments
Open
3 tasks done

[Bug] Tray icon image has excessively large dimensions #860

pdf opened this issue Sep 17, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@pdf
Copy link

pdf commented Sep 17, 2024

Discord Account

No response

Operating System

Arch Linux

Linux Only ~ Desktop Environment

Hyprland

Package Type

Flatpak / AUR

What happens when the bug or crash occurs?

The current system tray icon is a 1000px x 1000px image, which is significant overkill. This results in an uncompressed image data array sent via DBUS of ~4MB (1000 x 1000 x ARGB32).

What is the expected behaviour?

Ship a sensible image size - 64px is most common for tray icons, which results in an image data array of 16KB rather than 4MB.

Besides the current unnecessary memory usage and processing overhead, if/when #261 is merged, this is likely to have an even more significant impact, both on the performence of dynamically generating icons and on repeatedly shipping (and scaling/rendering by systrays) such large data chunks through the bus.

How do you recreate this bug or crash?

I have an in-house system tray and was wondering why only Vesktop failed to display an icon - it was overflowing the max default message size for GRPC of 4MB due to the massive icon pixmap data array.

Running dbus-monitor while toggling the systray icon setting will allow capturing the DBUS message if you'd like to see the data array being sent.

Debug Logs

N/A

Request Agreement

  • I have searched the existing issues and found no similar issue
  • I am using the latest Vesktop and Vencord versions
  • This issue occurs on an official release (not just the AUR or Nix packages)
@pdf pdf added the bug Something isn't working label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant