Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update & migrate types from discord-types package #2431

Open
Vendicated opened this issue May 9, 2024 · 0 comments
Open

Update & migrate types from discord-types package #2431

Vendicated opened this issue May 9, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Vendicated
Copy link
Owner

Vendicated commented May 9, 2024

We use the discord-types npm package for discord webpack module types. But this module hasn't properly been updated in years, so it is very outdated

We should

  • migrate all types we use to be included first party inside the Vencord repo. this is much more convenient than an npm package as it allows us to easily make changes to types. they could just be added alongside the existing types in src/webpack/common/types
  • update all types to add new fields and remove ones that no longer exist

To have as little work as possible, the best solution would be to grab an example entity from live Discord as json, and use the following tool to generate a typescript interface from it:
https://marketplace.visualstudio.com/items?itemName=GregorBiswanger.json2ts

@Vendicated Vendicated added enhancement New feature or request good first issue Good for newcomers labels May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant