Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: BlurNsfw not blurring embeds #2862

Merged
merged 14 commits into from
Oct 3, 2024
Merged

Conversation

ryawaa
Copy link
Contributor

@ryawaa ryawaa commented Sep 11, 2024

Closes #2837

demo:
image

src/utils/constants.ts Outdated Show resolved Hide resolved
@ryawaa ryawaa marked this pull request as draft September 11, 2024 12:31
@Nuckyz
Copy link
Collaborator

Nuckyz commented Sep 11, 2024

Isn't this just a fix of an already existing feature?

@ryawaa
Copy link
Contributor Author

ryawaa commented Sep 11, 2024

Isn't this just a fix of an already existing feature?

yeah, though the issue is labeled as a feature request. which should i follow?

@ryawaa
Copy link
Contributor Author

ryawaa commented Sep 11, 2024

Regex comparison:
old: \.embedWrapper(?=.+?channel_id:(\i)\.id) [.1-.2ms query]
current commit: \.container [.1-.2ms query]

other soln's:
(?<=Invite\(t,\s*(n)\).+?)\.container [~201.8ms query] (+ positive lookbehind may not be supported, + non-fixed)
Invite\(t,\s*(n)\).+?\.container[.2-.5ms query]

@ryawaa ryawaa marked this pull request as ready for review September 11, 2024 14:39
@ryawaa ryawaa changed the title feat(BlurNsfw): Additionally blur the embeds Fix: BlurNsfw not blurring embeds Sep 11, 2024
@ryawaa ryawaa marked this pull request as draft September 11, 2024 14:46
@ryawaa ryawaa marked this pull request as ready for review September 11, 2024 15:04
@ryawaa ryawaa mentioned this pull request Sep 30, 2024
src/plugins/blurNsfw/index.ts Outdated Show resolved Hide resolved
@Nuckyz Nuckyz changed the base branch from main to dev October 3, 2024 07:10
@Nuckyz Nuckyz enabled auto-merge (squash) October 3, 2024 07:11
@Nuckyz
Copy link
Collaborator

Nuckyz commented Oct 3, 2024

Thank you!

@Nuckyz Nuckyz merged commit 43b3c13 into Vendicated:dev Oct 3, 2024
1 check passed
@ryawaa ryawaa deleted the blurnsfw-embeds branch October 3, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST - BlurNSFW] - Blur Embedded Media
4 participants