-
Notifications
You must be signed in to change notification settings - Fork 31
feat: 4.24 update and VCV upstream changes #261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…dt/downstream-pfun
🤖 Gemini PR SummaryThis diff represents a significant refactoring of the The key changes and their purposes are:
Analysis of Changes
Last updated: 2025-12-17 16:08 UTC. See the main CI run for build status. |
…M/ArkLib into dt/downstream-pfun
|
@dtumad I'm going to base my OracleReduction refactor on top of this branch as well |
| Query := R | ||
| Response := R | ||
| answer := fun poly point => poly.eval point | ||
| def instPolynomial : OracleContext R (ReaderM R[X]) where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@quangvdao This is the basic approach I'm using as a replacement for interfaces (and not making them a type-class). Feels maybe overkill to be using reader monads and things for stuff like this but I think it might be useful long term to allow any monad.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine. Since this is no longer an instance the name should change to "polynomialOracleCtxt" or something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what is standard terminology for this. People just call this "(univariate) polynomial oracle"
…dt/downstream-pfun
…dt/downstream-pfun
|
@dtumad what's the status re: the oracle stuff we looked at during the last arklib meeting? |
…M/ArkLib into dt/downstream-pfun
🤖 Gemini PR SummaryThis pull request is a significant infrastructure update aimed at migrating the codebase to Lean 4.24.0 and aligning with major upstream architectural changes in the VCV (Verifiable Computation and Verification) library. Note: This is a Work-In-Progress (WIP). Several core modules (including Fiat-Shamir transformations and sequential compositions) have been temporarily commented out to facilitate the transition to the new oracle framework. Features
Refactoring
Fixes
Documentation
Analysis of Changes
✅ **Removed:** 49 `sorry`(s)
❌ **Added:** 26 `sorry`(s)
✏️ **Affected:** 1 `sorry`(s) (line number changed)
🎨 **Style Guide Adherence**Based on the provided style guide, here are the specific lines that violate the conventions: ArkLib/Data/CodingTheory/ProximityGap.lean
ArkLib/OracleReduction/Basic.lean
ArkLib/Data/Classes/DCast.lean
ArkLib/OracleReduction/FiatShamir/DuplexSponge/Security/BadEvents.lean
ArkLib/OracleReduction/Execution.lean
📄 **Per-File Summaries**
Last updated: 2026-01-07 05:06 UTC. |
|
Closed for an updated PR #286 |
Combined updates to 4.24 and changes needed for recent VCV changes.
WIP do not merge. Also need to change lakefile before merging once upstream PR merges