Migrate to oxlint (#1104)

Migrates JavaScript linting from eslint to oxlint

Author: VerifiedJoseph

.devcontainer/devcontainer.json

@@ -10,7 +10,7 @@
             "extensions": [
                 "EditorConfig.EditorConfig",
                 "bmewburn.vscode-intelephense-client",
-                "dbaeumer.vscode-eslint",
+                "oxc.oxc-vscode",
                 "streetsidesoftware.code-spell-checker"
             ]
         }

.github/workflows/code-quality-js.yml

@@ -14,7 +14,7 @@ permissions:
 
 jobs:
   eslint:
-    name: ESLint
+    name: Oxlint
     runs-on: ubuntu-22.04
     steps:
       - name: Checkout code
@@ -31,5 +31,5 @@ jobs:
       - name: Installing dependencies
         run: npm ci --ignore-scripts
 
-      - name: Run ESLint
+      - name: Run Oxlint
         run: npm run lint

.oxlintrc.json

@@ -0,0 +1,77 @@
+{
+  "$schema": "./node_modules/oxlint/configuration_schema.json",
+  "plugins": [],
+  "categories": {
+    "correctness": "off"
+  },
+  "env": {
+    "builtin": true,
+    "es2026": true,
+    "browser": true,
+    "node": true
+  },
+  "rules": {
+    "constructor-super": "error",
+    "for-direction": "error",
+    "getter-return": "error",
+    "no-async-promise-executor": "error",
+    "no-case-declarations": "error",
+    "no-class-assign": "error",
+    "no-compare-neg-zero": "error",
+    "no-cond-assign": "error",
+    "no-const-assign": "error",
+    "no-constant-binary-expression": "error",
+    "no-constant-condition": "error",
+    "no-control-regex": "error",
+    "no-debugger": "error",
+    "no-delete-var": "error",
+    "no-dupe-class-members": "error",
+    "no-dupe-else-if": "error",
+    "no-dupe-keys": "error",
+    "no-duplicate-case": "error",
+    "no-empty": "error",
+    "no-empty-character-class": "error",
+    "no-empty-pattern": "error",
+    "no-empty-static-block": "error",
+    "no-ex-assign": "error",
+    "no-extra-boolean-cast": "error",
+    "no-fallthrough": "error",
+    "no-func-assign": "error",
+    "no-global-assign": "error",
+    "no-import-assign": "error",
+    "no-invalid-regexp": "error",
+    "no-irregular-whitespace": "error",
+    "no-loss-of-precision": "error",
+    "no-misleading-character-class": "error",
+    "no-new-native-nonconstructor": "error",
+    "no-nonoctal-decimal-escape": "error",
+    "no-obj-calls": "error",
+    "no-prototype-builtins": "error",
+    "no-redeclare": "error",
+    "no-regex-spaces": "error",
+    "no-self-assign": "error",
+    "no-setter-return": "error",
+    "no-shadow-restricted-names": "error",
+    "no-sparse-arrays": "error",
+    "no-this-before-super": "error",
+    "no-unassigned-vars": "error",
+    "no-undef": "error",
+    "no-unexpected-multiline": "error",
+    "no-unreachable": "error",
+    "no-unsafe-finally": "error",
+    "no-unsafe-negation": "error",
+    "no-unsafe-optional-chaining": "error",
+    "no-unused-labels": "error",
+    "no-unused-private-class-members": "error",
+    "no-unused-vars": "error",
+    "no-useless-assignment": "error",
+    "no-useless-backreference": "error",
+    "no-useless-catch": "error",
+    "no-useless-escape": "error",
+    "no-with": "error",
+    "preserve-caught-error": "error",
+    "require-yield": "error",
+    "use-isnan": "error",
+    "valid-typeof": "error"
+  }
+}

eslint.config.mjs

@@ -192,8 +192,8 @@ export class FilterAddDialog extends ViewGroupDialogs {
     const select = document.getElementById(this.#getId('filter-value'))
     select.innerText = ''
 
-    let valueName = ''
-    let textValueName = ''
+    let valueName
+    let textValueName
     switch (type) {
       case 'address':
         valueName = 'address'
@@ -227,7 +227,7 @@ export class FilterAddDialog extends ViewGroupDialogs {
 
     const timeTypes = ['hour', 'minute', 'second']
 
-    let data = []
+    let data
     if (type === 'version') {
       data = [{ number: 4 }, { number: 6 }]
     } else if (timeTypes.includes(type)) {

frontend/js/class/Dialog/FilterAddDialog.js

@@ -49,8 +49,8 @@ export class Pagination {
    * Set buttons
    */
   setButtons () {
-    let prev = null
-    let next = null
+    let prev
+    let next
     const last = this.#pageCount
 
     if (this.#pageCount > 0) {