Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stdout insights should not include HTML #69

Open
Horgix opened this issue May 21, 2021 · 1 comment
Open

Stdout insights should not include HTML #69

Horgix opened this issue May 21, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@Horgix
Copy link
Collaborator

Horgix commented May 21, 2021

Currently, the stdout helpful insights from the Test step of recipes such as classification include HTML tags:

Test | Ep. 0 It 1 | {'acc': '0.0892', 'loss': '2.6739', 'cm': '<table><tr><th>Pred\\', 'report': '<h1>Best predictions', 'table': '\n        <style>\n   '}

I believe that these should not be part of the message since no terminal will render it and it only makes things harder to read!

@Horgix Horgix added the enhancement New feature or request label May 21, 2021
@Vermeille
Copy link
Owner

My thinking was that some NLP people might actually want to write some textual output to the terminal.
However, as of today, StdoutLogger will print everything the state contains, including strings and VisdomLogger will render strings as HTML. I have no idea how to pull this off cleanly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants