feat: add unit test for markerplace, fee distribution, auction manager.

- Fix contract design issues

Author: am-miracle

TEST_GUIDE.md

@@ -103,14 +103,6 @@ forge test --gas-report --match-contract YourContract
 forge test --watch
 ```
 
-
-
-### **Short-Term (Improve Coverage)**
-5. Add VerificationRegistry tests
-6. Add ReputationManager tests
-7. Add NFT contract tests
-8. Add integration tests
-
 ### **Long-Term (Advanced Testing)**
 9. Add invariant tests
 10. Add property-based tests

src/access/RoleManager.sol

@@ -30,10 +30,6 @@ contract RoleManager is AccessControl, Pausable {
     error AlreadyHasRole(bytes32 role, address account);
     error LengthMismatch(uint256 rolesLength, uint256 accountsLength);
 
-    // ============================================
-    //             ROLES
-    // ============================================
-
     /// @notice General admin role for day-to-day operations
     bytes32 public constant ADMIN_ROLE = keccak256("ADMIN_ROLE");
 
@@ -49,10 +45,6 @@ contract RoleManager is AccessControl, Pausable {
     /// @notice Can update platform fees and fee collector
     bytes32 public constant FEE_MANAGER_ROLE = keccak256("FEE_MANAGER_ROLE");
 
-    // ============================================
-    //           STATE VARIABLES
-    // ============================================
-
     /// @notice Timelock duration for sensitive role changes (24 hours)
     uint256 public constant ROLE_CHANGE_TIMELOCK = 24 hours;
 
@@ -66,42 +58,18 @@ contract RoleManager is AccessControl, Pausable {
     //                 EVENTS
     // ============================================
 
-    /**
-     * @notice Emitted when a role grant is scheduled
-     */
     event RoleGrantScheduled(
         bytes32 indexed role, address indexed account, address indexed scheduler, uint256 executeAfter
     );
 
-    /**
-     * @notice Emitted when a scheduled role grant is executed
-     */
     event RoleGrantExecuted(bytes32 indexed role, address indexed account, address indexed executor);
 
-    /**
-     * @notice Emitted when a scheduled role grant is cancelled
-     */
     event RoleGrantCancelled(bytes32 indexed role, address indexed account, address indexed canceller);
 
-    /**
-     * @notice Emitted when contract is paused
-     */
     event EmergencyPaused(address indexed pauser, string reason);
 
-    /**
-     * @notice Emitted when contract is unpaused
-     */
     event EmergencyUnpaused(address indexed unpauser);
 
-    // ============================================
-    //             CONSTRUCTOR
-    // ============================================
-
-    /**
-     * @notice Initialize role manager
-     * @param initialAdmin Address to receive DEFAULT_ADMIN_ROLE
-     * @dev Grants all roles to initial admin for initial setup
-     */
     constructor(address initialAdmin) {
         if (initialAdmin == address(0)) {
             revert InvalidAddress(initialAdmin);
@@ -122,10 +90,6 @@ contract RoleManager is AccessControl, Pausable {
         roleMembers[FEE_MANAGER_ROLE].push(initialAdmin);
     }
 
-    // ============================================
-    //        ROLE MANAGEMENT WITH TIMELOCK
-    // ============================================
-
     /**
      * @notice Schedule a role grant with timelock (for sensitive roles)
      * @param role Role identifier
@@ -242,10 +206,6 @@ contract RoleManager is AccessControl, Pausable {
         }
     }
 
-    // ============================================
-    //        EMERGENCY CONTROLS
-    // ============================================
-
     /**
      * @notice Pause all marketplace operations
      * @param reason Reason for pausing
@@ -325,10 +285,6 @@ contract RoleManager is AccessControl, Pausable {
         return paused();
     }
 
-    // ============================================
-    //          UTILITY FUNCTIONS
-    // ============================================
-
     /**
      * @notice Batch grant roles to multiple addresses
      * @param roles Array of role identifiers