Spinning icons since 3.10.4 (including 3.10.5)

[nodarkthings]

Describe the bug
At launch, all icons keep spinning for 1 minute (when it stopped quite immediately before) and it looks like not downloading anything. The spinning icon disappears when I click on it.

To Reproduce
Just launch (tested on 10.14 and 12).

Screenshots
Add screenshots to help explain your problem, if possible.

Please complete the following information:

• Vienna version 3.10.4+
• OS version: 10.14 and 12

Additional information:
v3.10.3 is perfect.

[Eitot]

I cannot reproduce this in Tahoe, I have to check the older versions to reproduce this.

[slbug]

same issue + constantly duplicating existing articles. when click read all, duplications disappears until next refresh

Version 3.10.5 :4c2b65d9: (9174)

Tahoe 26.4.1 (25E253)

[slbug]

i think this one related #2137

and both caused by #2127

[nodarkthings]

Not fixed in 3.10.6 (tested on 10.14)

[barijaona]

Make sure you have status bar enabled.

Do you see the number in the "Queue (…) Refreshing subscriptions" status message decreasing ?

[nodarkthings]

Make sure you have status bar enabled.

=> it is

Do you see the number in the "Queue (…) Refreshing subscriptions" status message decreasing ?

=> no. same behaviour as 3.10.4 and 3.10.5 as described in my first post. Status bar says "Refreshing OK" (in French 😉) but icons keep spinning for a minute or so.

[barijaona]

Could you try the latest beta https://github.com/ViennaRSS/vienna-rss/releases/tag/v%2F3.11.0_beta2 on your macOS 12 machine and check if you get the same behavior ?

[nodarkthings]

Works better! Most of them stop churning up fast except some, I've restarted the app ten times and amongst those who keep spinning quite every time are:
https://feeds.feedburner.com/HaveIBeenPwnedLatestBreaches
https://www.theguardian.com/news/series/the-audio-long-read/rss
https://feeds.feedburner.com/tedtalks_video
https://www.futura-sciences.com/rss/sante/actualites.xml
https://www.theguardian.com/news/series/the-audio-long-read/rss
https://themasteringshow.com/feed/
... but not always... and sometimes others do... 🙄
It can stop after 10s or... 1.5 minute...

[cwalther]

I am seeing a similar problem. It has probably started with the update from 3.10.3 to 3.10.6, but I am not sure. After refreshing the feeds (not immediately after starting the application), Vienna takes hours (literally) using 100% CPU while some of the spinners in the folder list are still spinning and the Activity window still says “Retrieving articles” for the respective folders, whereas the status bar has already counted down to zero and changed to “Refresh completed”.

Sampling the process during that time always shows stack traces like this:

    1588 Thread_18988363   DispatchQueue_353: uk.co.opencommunity.vienna2.refresh  (serial)
    + 1588 start_wqthread  (in libsystem_pthread.dylib) + 13  [0x7fff669223fd]
    +   1588 _pthread_wqthread  (in libsystem_pthread.dylib) + 421  [0x7fff66922611]
    +     1588 _dispatch_workloop_worker_thread  (in libdispatch.dylib) + 598  [0x7fff666f16ed]
    +       1588 _dispatch_lane_invoke  (in libdispatch.dylib) + 385  [0x7fff666e9396]
    +         1588 _dispatch_lane_serial_drain  (in libdispatch.dylib) + 602  [0x7fff666e88e0]
    +           1588 _dispatch_client_callout  (in libdispatch.dylib) + 8  [0x7fff666e263d]
    +             1588 _dispatch_call_block_and_release  (in libdispatch.dylib) + 12  [0x7fff666e15f8]
    +               1588 ???  (in Vienna)  load address 0x102e98000 + 0x74802  [0x102f0c802]
    +                 1588 ???  (in Vienna)  load address 0x102e98000 + 0x7638f  [0x102f0e38f]
    +                   1588 ???  (in Vienna)  load address 0x102e98000 + 0x4c95  [0x102e9cc95]
    +                     909 ???  (in Vienna)  load address 0x102e98000 + 0x53e0  [0x102e9d3e0]
    +                     ! 909 -[NSCache setObject:forKey:cost:]  (in CoreFoundation) + 201  [0x7fff3b47760f]
    +                     !   909 cache_set_and_retain  (in libcache.dylib) + 1250  [0x7fff665b2d83]
    +                     !     909 _value_entry_remove  (in libcache.dylib) + 113  [0x7fff665b373b]
    +                     !       909 __NSCacheValueRelease  (in CoreFoundation) + 95  [0x7fff3b4b55f6]
    +                     !         909 __NSCacheCallDelegateWillEvictObjectCallbackWithValue  (in CoreFoundation) + 70  [0x7fff3b56d4fc]
    +                     !           908 ???  (in Vienna)  load address 0x102e98000 + 0x6dfb  [0x102e9edfb]
    +                     !           : 639 -[NSMutableArray removeObject:]  (in CoreFoundation) + 173  [0x7fff3b45c8f1]
    +                     !           : | 304 -[__NSCFString isEqual:]  (in CoreFoundation) + 66  [0x7fff3b432100]
    +                     !           : | + 273 __CFStringEqual  (in CoreFoundation) + 829,30,...  [0x7fff3b4f2dda,0x7fff3b4f2abb,...]
    +                     !           : | + 29 _CFStringEqual  (in CoreFoundation) + 4  [0x7fff3b3ff6df]
    +                     !           : | + 2 __CFStringEqual  (in CoreFoundation) + 242  [0x7fff3b4f2b8f]
    +                     !           : | +   2 _platform_memcmp  (in libsystem_platform.dylib) + 7,303  [0x7fff66917747,0x7fff6691786f]
    +                     !           : | 244 -[__NSCFString isEqual:]  (in CoreFoundation) + 38,329,...  [0x7fff3b4320e4,0x7fff3b432207,...]
    +                     !           : | 91 objc_msgSend  (in libobjc.A.dylib) + 41,33,...  [0x7fff64f516a9,0x7fff64f516a1,...]
    +                     !           : 163 -[NSMutableArray removeObject:]  (in CoreFoundation) + 155  [0x7fff3b45c8df]
    +                     !           : | 82 -[__NSArrayM objectAtIndex:]  (in CoreFoundation) + 4,107,...  [0x7fff3b4215f0,0x7fff3b421657,...]
    +                     !           : | 81 objc_msgSend  (in libobjc.A.dylib) + 0,33,...  [0x7fff64f51680,0x7fff64f516a1,...]
    +                     !           : 106 -[NSMutableArray removeObject:]  (in CoreFoundation) + 139,173,...  [0x7fff3b45c8cf,0x7fff3b45c8f1,...]
    +                     !           1 objc_release  (in libobjc.A.dylib) + 98  [0x7fff64f53692]
    +                     655 ???  (in Vienna)  load address 0x102e98000 + 0x5417  [0x102e9d417]
    +                     ! 562 -[NSArray containsObject:]  (in CoreFoundation) + 239  [0x7fff3b45c7da]
    +                     ! : 272 -[__NSCFString isEqual:]  (in CoreFoundation) + 38,6,...  [0x7fff3b4320e4,0x7fff3b4320c4,...]
    +                     ! : 243 -[__NSCFString isEqual:]  (in CoreFoundation) + 66  [0x7fff3b432100]
    +                     ! : | 211 __CFStringEqual  (in CoreFoundation) + 836,4,...  [0x7fff3b4f2de1,0x7fff3b4f2aa1,...]
    +                     ! : | 31 __CFStringEqual  (in CoreFoundation) + 242  [0x7fff3b4f2b8f]
    +                     ! : | + 31 _platform_memcmp  (in libsystem_platform.dylib) + 288,312  [0x7fff66917860,0x7fff66917878]
    +                     ! : | 1 _CFStringEqual  (in CoreFoundation) + 0  [0x7fff3b3ff6db]
    +                     ! : 47 objc_msgSend  (in libobjc.A.dylib) + 46,23,...  [0x7fff64f516ae,0x7fff64f51697,...]
    +                     ! 93 -[NSArray containsObject:]  (in CoreFoundation) + 227,185,...  [0x7fff3b45c7ce,0x7fff3b45c7a4,...]
    +                     24 ???  (in Vienna)  load address 0x102e98000 + 0x539c  [0x102e9d39c]
    +                       24 ???  (in Vienna)  load address 0x102e98000 + 0x4b75  [0x102e9cb75]
    +                         24 -[NSCache objectForKey:]  (in CoreFoundation) + 61  [0x7fff3b4773ac]
    +                           24 cache_get_and_retain  (in libcache.dylib) + 157  [0x7fff665b23a6]
    +                             24 _entry_get_optionally_checking_collisions  (in libcache.dylib) + 42  [0x7fff665b259a]
    +                               24 CFHash  (in CoreFoundation) + 65  [0x7fff3b3fee91]

Taking a look at -[Folder cache: willEvictObject:], it strikes me that it removes objects from an array by value, which is probably not an efficient operation.

Notably, I have 643 folders, the largest of which contains 111684 messages, 821205 messages total (messages.db is 1.4 GB).

I cannot try 3.11.0_beta2 because it doesn’t run on macOS 10.14.6. I hope once the bug is identified and fixed, the fix can be backported to 3.10.

[cwalther]

Also, sometimes, during the spinning period, CPU usage will drop to near zero in what appears to be a deadlock. No further progress on the update is made, I can still click around in the GUI, but trying to quit the application makes it unresponsive.

In the sampling, I suspect a deadlock between these two threads (I realize it’s not very helpful without symbols from Vienna, since there are multiple calls of -[NSCache objectForKey:] within @synchronized(self) in Folder.m, but I haven’t gotten around to building it myself yet):

    2758 Thread_28314751   DispatchQueue_353: uk.co.opencommunity.vienna2.refresh  (serial)
    + 2758 start_wqthread  (in libsystem_pthread.dylib) + 13  [0x7fff669223fd]
    +   2758 _pthread_wqthread  (in libsystem_pthread.dylib) + 421  [0x7fff66922611]
    +     2758 _dispatch_workloop_worker_thread  (in libdispatch.dylib) + 598  [0x7fff666f16ed]
    +       2758 _dispatch_lane_invoke  (in libdispatch.dylib) + 385  [0x7fff666e9396]
    +         2758 _dispatch_lane_serial_drain  (in libdispatch.dylib) + 602  [0x7fff666e88e0]
    +           2758 _dispatch_client_callout  (in libdispatch.dylib) + 8  [0x7fff666e263d]
    +             2758 _dispatch_call_block_and_release  (in libdispatch.dylib) + 12  [0x7fff666e15f8]
    +               2758 ???  (in Vienna)  load address 0x1087c2000 + 0x74802  [0x108836802]
    +                 2758 ???  (in Vienna)  load address 0x1087c2000 + 0x7638f  [0x10883838f]
    +                   2758 ???  (in Vienna)  load address 0x1087c2000 + 0x4cbe  [0x1087c6cbe]
    +                     2758 -[NSCache objectForKey:]  (in CoreFoundation) + 232  [0x7fff3b477457]
    +                       2758 cache_release_value  (in libcache.dylib) + 265  [0x7fff665b3253]
    +                         2758 _value_entry_remove  (in libcache.dylib) + 113  [0x7fff665b373b]
    +                           2758 __NSCacheValueRelease  (in CoreFoundation) + 95  [0x7fff3b4b55f6]
    +                             2758 __NSCacheCallDelegateWillEvictObjectCallbackWithValue  (in CoreFoundation) + 70  [0x7fff3b56d4fc]
    +                               2758 ???  (in Vienna)  load address 0x1087c2000 + 0x6dac  [0x1087c8dac]
    +                                 2758 objc_sync_enter  (in libobjc.A.dylib) + 27  [0x7fff64f5637e]
    +                                   2758 _os_unfair_lock_lock_slow  (in libsystem_platform.dylib) + 143  [0x7fff66918c3a]
    +                                     2758 __ulock_wait  (in libsystem_kernel.dylib) + 10  [0x7fff668669da]
    2758 Thread_28319931   DispatchQueue_185: fmdb.<FMDatabaseQueue: 0x6000035bafd0>  (serial)
    + 2758 start_wqthread  (in libsystem_pthread.dylib) + 13  [0x7fff669223fd]
    +   2758 _pthread_wqthread  (in libsystem_pthread.dylib) + 583  [0x7fff669226b3]
    +     2758 _dispatch_worker_thread2  (in libdispatch.dylib) + 90  [0x7fff666f0b46]
    +       2758 _dispatch_root_queue_drain  (in libdispatch.dylib) + 324  [0x7fff666f03bc]
    +         2758 _dispatch_queue_override_invoke  (in libdispatch.dylib) + 763  [0x7fff666e4a53]
    +           2758 _dispatch_client_callout  (in libdispatch.dylib) + 8  [0x7fff666e263d]
    +             2758 _dispatch_call_block_and_release  (in libdispatch.dylib) + 12  [0x7fff666e15f8]
    +               2758 ???  (in Vienna)  load address 0x1087c2000 + 0x4bfc9  [0x10880dfc9]
    +                 2758 ???  (in Vienna)  load address 0x1087c2000 + 0x6116  [0x1087c8116]
    +                   2758 ???  (in Vienna)  load address 0x1087c2000 + 0x6116  [0x1087c8116]
    +                     2758 ???  (in Vienna)  load address 0x1087c2000 + 0x6116  [0x1087c8116]
    +                       2758 ???  (in Vienna)  load address 0x1087c2000 + 0x64ba  [0x1087c84ba]
    +                         2758 ???  (in Vienna)  load address 0x1087c2000 + 0x6781  [0x1087c8781]
    +                           2758 ???  (in Vienna)  load address 0x1087c2000 + 0x137c7  [0x1087d57c7]
    +                             2758 ???  (in Vienna)  load address 0x1087c2000 + 0xde379  [0x1088a0379]
    +                               2758 _dispatch_lane_barrier_sync_invoke_and_complete  (in libdispatch.dylib) + 60  [0x7fff666ee129]
    +                                 2758 _dispatch_client_callout  (in libdispatch.dylib) + 8  [0x7fff666e263d]
    +                                   2758 ???  (in Vienna)  load address 0x1087c2000 + 0xde3df  [0x1088a03df]
    +                                     2758 ???  (in Vienna)  load address 0x1087c2000 + 0x13ebf  [0x1087d5ebf]
    +                                       2758 ???  (in Vienna)  load address 0x1087c2000 + 0x4b75  [0x1087c6b75]
    +                                         2758 -[NSCache objectForKey:]  (in CoreFoundation) + 61  [0x7fff3b4773ac]
    +                                           2758 cache_get_and_retain  (in libcache.dylib) + 114  [0x7fff665b237b]
    +                                             2758 _os_unfair_lock_lock_slow  (in libsystem_platform.dylib) + 143  [0x7fff66918c3a]
    +                                               2758 __ulock_wait  (in libsystem_kernel.dylib) + 10  [0x7fff668669da]

[barijaona]

Can you provide feedback regarding versions 3.10.7 and 3.11.0 Beta 3 ?