Skip to content

Commit 4a5d41b

Browse files
author
Aaron Cohen
committed
add better contrast to header
1 parent 0829a52 commit 4a5d41b

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

courseup/src/app/Content.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ export default function Content({ children }: any): React.ReactNode {
1010
return (
1111
<>
1212
<Header blurBackground={blurBackground} setBlurBackground={setBlurBackground} />
13-
<div className={classNames('pointer-events-none transition-all', { 'blur-sm': blurBackground })}>{children}</div>
13+
<div className={classNames('pointer-events-none transition-all', { 'blur-md': blurBackground })}>{children}</div>
1414
</>
1515
);
1616
}

courseup/src/components/common/header/components/MobileNavbar/MobileNavbar.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@ export function MobileNavbar({ blurBackground, setBlurBackground }: any): React.
1212
const unblurListenerAdded = useRef(false);
1313

1414
const onClick = (): void => {
15-
// TODO: also, the outline of the menu still isn't really that visible (that was the point of adding blur)
16-
// TODO: need to find some way to make it look a little bit better and add some contrast
1715
const unBlurBackground = () => {
1816
if (!blurBackground) {
1917
if (!menuOverrride.current) {
@@ -38,10 +36,12 @@ export function MobileNavbar({ blurBackground, setBlurBackground }: any): React.
3836
<ul
3937
tabIndex={0}
4038
className={classNames(
41-
'menu dropdown-content rounded-md bg-base-100 p-0 shadow w-72',
39+
'menu dropdown-content rounded-md bg-base-300 p-0 shadow w-72',
4240
'px-4 py-4 mt-4',
4341
'z-10',
44-
{ hidden: !blurBackground }
42+
{
43+
hidden: !blurBackground,
44+
}
4545
)}
4646
onClick={() => (menuOverrride.current = true)}
4747
>

courseup/src/components/common/header/containers/HeaderContainer.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import MobileNavbar from '../components/MobileNavbar';
55

66
export function HeaderContainer({ blurBackground, setBlurBackground }: any) {
77
return (
8-
<div className="navbar flex items-center bg-base-100 shadow-md px-2 md:px-4 lg:px-5">
8+
<div className="navbar flex items-center bg-base-300 shadow-md px-2 md:px-4 lg:px-5">
99
<div className="navbar-start">
1010
<MobileNavbar blurBackground={blurBackground} setBlurBackground={setBlurBackground} />
1111
<a href="/" className="text-xl font-bold">

0 commit comments

Comments
 (0)