Skip to content

Commit 89c01f0

Browse files
refactor(Application): Remove modules (#2249)
1 parent cf8bade commit 89c01f0

File tree

94 files changed

+562
-1345
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

94 files changed

+562
-1345
lines changed

src/app/app-routing.module.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,11 @@ const routes: Routes = [
3232
},
3333
{
3434
path: 'forgot',
35-
loadChildren: () => import('./forgot/forgot-routing.module').then((m) => m.ForgotRoutingModule)
35+
loadChildren: () => import('./forgot/forgot.routes').then((m) => m.routes)
3636
},
3737
{
3838
path: 'help',
39-
loadChildren: () => import('./help/help-routing.module').then((m) => m.HelpRoutingModule)
39+
loadChildren: () => import('./help/help.routes').then((m) => m.routes)
4040
},
4141
{
4242
path: 'join',

src/app/authoring-tool/edit-component-advanced/edit-component-advanced.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@ import { Component as WISEComponent } from '../../../assets/wise5/common/Compone
1515
import { components } from '../../../assets/wise5/components/Components';
1616

1717
@Component({
18-
templateUrl: './edit-component-advanced.component.html',
18+
imports: [MatDivider, MatDialogModule, MatButtonModule],
1919
styles: [
2020
'.mat-divider { margin: 0 -16px; } .mat-mdc-dialog-content { padding-top: 10px !important; padding-bottom: 10px !important; }'
2121
],
22-
imports: [MatDivider, MatDialogModule, MatButtonModule]
22+
templateUrl: './edit-component-advanced.component.html'
2323
})
2424
export class EditComponentAdvancedComponent {
2525
@ViewChild('component') private componentElementRef: ElementRef;

src/app/classroom-monitor/alert-status-corner/alert-status-corner.component.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@ import { Component, Input } from '@angular/core';
33
import { MatTooltipModule } from '@angular/material/tooltip';
44

55
@Component({
6-
imports: [CommonModule, MatTooltipModule],
7-
selector: 'alert-status-corner',
8-
styleUrl: 'alert-status-corner.scss',
9-
templateUrl: 'alert-status-corner.component.html'
6+
imports: [CommonModule, MatTooltipModule],
7+
selector: 'alert-status-corner',
8+
styleUrl: 'alert-status-corner.scss',
9+
templateUrl: 'alert-status-corner.component.html'
1010
})
1111
export class AlertStatusCornerComponent {
1212
@Input() hasNewAlert: boolean;

src/app/classroom-monitor/milestones/milestones.component.ts

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
import { Component } from '@angular/core';
1+
import { Component, Injector } from '@angular/core';
2+
import { createCustomElement } from '@angular/elements';
23
import { MatDialog } from '@angular/material/dialog';
34
import { Subscription } from 'rxjs';
45
import { MilestoneDetailsDialogComponent } from '../../../assets/wise5/classroomMonitor/classroomMonitorComponents/milestones/milestone-details-dialog/milestone-details-dialog.component';
@@ -12,6 +13,8 @@ import { MatCard, MatCardContent } from '@angular/material/card';
1213
import { MatProgressSpinner } from '@angular/material/progress-spinner';
1314
import { NgClass } from '@angular/common';
1415
import { MatIcon } from '@angular/material/icon';
16+
import { MilestoneReportDataComponent } from '../../teacher/milestone/milestone-report-data/milestone-report-data.component';
17+
import { MilestoneReportGraphComponent } from '../../teacher/milestone/milestone-report-graph/milestone-report-graph.component';
1518

1619
@Component({
1720
imports: [MatCard, MatCardContent, MatProgressSpinner, NgClass, MatIcon],
@@ -27,9 +30,23 @@ export class MilestonesComponent {
2730
private achievementService: AchievementService,
2831
private annotationService: AnnotationService,
2932
private milestoneService: MilestoneService,
33+
private injector: Injector,
3034
private dialog: MatDialog,
3135
private dataService: TeacherDataService
32-
) {}
36+
) {
37+
if (!customElements.get('milestone-report-data')) {
38+
customElements.define(
39+
'milestone-report-data',
40+
createCustomElement(MilestoneReportDataComponent, { injector: this.injector })
41+
);
42+
}
43+
if (!customElements.get('milestone-report-graph')) {
44+
customElements.define(
45+
'milestone-report-graph',
46+
createCustomElement(MilestoneReportGraphComponent, { injector: this.injector })
47+
);
48+
}
49+
}
3350

3451
ngOnInit() {
3552
this.loadProjectMilestones();

src/app/classroom-monitor/status-icon/status-icon.component.html

Lines changed: 0 additions & 3 deletions
This file was deleted.

src/app/classroom-monitor/status-icon/status-icon.component.ts

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,18 @@ import { MatIconModule } from '@angular/material/icon';
33
import { MatTooltipModule } from '@angular/material/tooltip';
44

55
@Component({
6-
imports: [MatIconModule, MatTooltipModule],
7-
selector: 'status-icon',
8-
templateUrl: 'status-icon.component.html'
6+
imports: [MatIconModule, MatTooltipModule],
7+
selector: 'status-icon',
8+
template: `
9+
<mat-icon
10+
class="{{ class }}"
11+
tabindex="0"
12+
matTooltip="{{ tooltip }}"
13+
matTooltipPosition="above"
14+
>
15+
{{ name }}
16+
</mat-icon>
17+
`
918
})
1019
export class StatusIconComponent {
1120
@Input() class: string;

src/app/forgot/forgot-user-password-complete/forgot-user-password-complete.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ import { MatButton } from '@angular/material/button';
44
import { MatCard, MatCardContent } from '@angular/material/card';
55

66
@Component({
7-
templateUrl: './forgot-user-password-complete.component.html',
8-
imports: [MatCard, MatCardContent, MatButton]
7+
imports: [MatCard, MatCardContent, MatButton],
8+
templateUrl: './forgot-user-password-complete.component.html'
99
})
1010
export class ForgotUserPasswordCompleteComponent {
1111
@Input() username: string;
Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
import { NgModule } from '@angular/core';
2-
import { Routes, RouterModule } from '@angular/router';
1+
import { Routes } from '@angular/router';
32
import { ForgotComponent } from './forgot.component';
43
import { ForgotHomeComponent } from './forgot-home/forgot-home.component';
54
import { ForgotStudentComponent } from './student/forgot-student/forgot-student.component';
@@ -15,7 +14,7 @@ import { ForgotTeacherPasswordVerifyComponent } from './teacher/forgot-teacher-p
1514
import { ForgotTeacherPasswordChangeComponent } from './teacher/forgot-teacher-password-change/forgot-teacher-password-change.component';
1615
import { ForgotUserPasswordCompleteComponent } from './forgot-user-password-complete/forgot-user-password-complete.component';
1716

18-
const routes: Routes = [
17+
export const routes: Routes = [
1918
{
2019
path: '',
2120
component: ForgotComponent,
@@ -37,9 +36,3 @@ const routes: Routes = [
3736
]
3837
}
3938
];
40-
41-
@NgModule({
42-
imports: [RouterModule.forChild(routes)],
43-
exports: [RouterModule]
44-
})
45-
export class ForgotRoutingModule {}

src/app/help/help.component.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ import { Component } from '@angular/core';
22
import { RouterModule } from '@angular/router';
33

44
@Component({
5-
imports: [RouterModule],
6-
selector: 'app-help',
7-
styleUrl: './help.component.scss',
8-
templateUrl: './help.component.html'
5+
imports: [RouterModule],
6+
selector: 'app-help',
7+
styleUrl: './help.component.scss',
8+
templateUrl: './help.component.html'
99
})
1010
export class HelpComponent {}
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,11 @@
1-
import { NgModule } from '@angular/core';
2-
import { RouterModule, Routes } from '@angular/router';
1+
import { Routes } from '@angular/router';
32
import { HelpComponent } from './help.component';
43
import { HelpHomeComponent } from './help-home/help-home.component';
54
import { GettingStartedComponent } from './faq/getting-started/getting-started.component';
65
import { TeacherFaqComponent } from './faq/teacher-faq/teacher-faq.component';
76
import { StudentFaqComponent } from './faq/student-faq/student-faq.component';
87

9-
const helpRoutes: Routes = [
8+
export const routes: Routes = [
109
{
1110
path: '',
1211
component: HelpComponent,
@@ -18,9 +17,3 @@ const helpRoutes: Routes = [
1817
]
1918
}
2019
];
21-
22-
@NgModule({
23-
imports: [RouterModule.forChild(helpRoutes)],
24-
exports: [RouterModule]
25-
})
26-
export class HelpRoutingModule {}

0 commit comments

Comments
 (0)