-
Notifications
You must be signed in to change notification settings - Fork 2
Fix noon/midnight time display by deriving from numeric time values #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Co-authored-by: jsit <[email protected]>
Co-authored-by: jsit <[email protected]>
jsit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What the ScheduleService should probably do is derive the time display from the <time> XML element (which represents minutes after midnight) to generate the time string, rather than using <time_str> at all.
|
@copilot Address my feedback please. |
|
@copilot Address my feedback please. |
|
@copilot Address my feedback please |
Co-authored-by: jsit <[email protected]>
The schedule page displays times using "12:00n" for noon and "12:00m" for midnight—a non-standard convention. These should use standard AM/PM format.
Changes
ScheduleService.formatTime(): Updated to derive time display from the<time>XML element (minutes after midnight) instead of using<time_str>. Converts numeric values to 12-hour formatted strings (e.g., 0 → "12:00am", 720 → "12:00pm")SchedulePage: Updated to pass
show.time(numeric) instead ofshow.time_strtoformatTime()Tests: Added comprehensive unit tests for
formatTime()with numeric inputs and integration tests verifying display inSchedulePageMock data: Added noon/midnight show examples for test coverage
Original prompt
<issue_description>Currently on the Schedule Page, noon is represented as "12:00n" and midnight as "12:00m," a convention I've never seen before.
Instead, these should be printed as "12:00pm" and "12:00am".</issue_description>
Comments on the Issue (you are @copilot in this section)
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.