feat: add show description to show detail page (#152) #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds show descriptions to the show detail page by fetching schedule data and passing the description through navigation parameters.
Key Changes:
- Added
getShowByIdmethod toScheduleServiceto retrieve individual show details including descriptions - Updated
ShowDetailsPageto accept and displayshowDescriptionparameter - Modified
SchedulePageto fetch show details and pass description when navigating to show details
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/services/ScheduleService.ts |
Added getShowById method to fetch show details by ID from the schedule |
src/app/Schedule/ShowDetailsPage.tsx |
Updated route params to include showDescription and added UI to display it with updated styling |
src/app/Schedule/SchedulePage.tsx |
Modified handleShowPress to fetch show details and pass description to navigation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #152, and sets us up to also show email address, URL, etc on show details page.