Refactor/identity keys persistence and signing (#154)

devceline · web-flow · commit 458c711cc9c6 · 2023-12-18T17:09:08.000+01:00
* chore: refactor signature logic by adding util functions per step * chore: refactor persistence logic * test: finalize unit test refactor * chore: run prettier * chore: run lint * chore: ignore ts5.0 deprecate * chore: use utils sub module * chore: bump major version * Revert "chore: bump major version" This reverts commit 993e90f. * chore(release): bump major version using changeset * chore: update changelog * chore: replace viem with ethersproject * chore: bump version using changeset * chore: run prettier
diff --git a/misc/identity-keys/CHANGELOG.md b/misc/identity-keys/CHANGELOG.md
@@ -1,5 +1,23 @@
 # @walletconnect/identity-keys
 
+## 1.0.1
+
+### Patch Changes
+
+- Replace viem with @ethersproject/transactions and @ethersproject/hash to optimize for size
+
+## 1.0.0
+
+### Major Changes
+
+- Refactor registration to be multi function, with the following flow:
+
+  - `prepareRegistration`,
+  - sign `message` independently,
+  - then pass that `signature` along with `registerParams` from `prepareRegistration` into register.
+
+- Removes `onSign` function, instead passing signature to the second part of a duo function operation.
+
 ## 0.2.3
 
 ### Patch Changes
diff --git a/misc/identity-keys/package.json b/misc/identity-keys/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@walletconnect/identity-keys",
-  "version": "0.2.3",
+  "version": "1.0.1",
   "description": "Utilities to register, resolve and unregister identity keys",
   "keywords": [
     "identity",
@@ -51,6 +51,8 @@
     "webpack-cli": "^5.0.1"
   },
   "dependencies": {
+    "@ethersproject/hash": "^5.7.0",
+    "@ethersproject/transactions": "^5.7.0",
     "@noble/ed25519": "^1.7.1",
     "@walletconnect/cacao": "1.0.2",
     "@walletconnect/core": "^2.10.1",
diff --git a/misc/identity-keys/src/identity-keys.ts b/misc/identity-keys/src/identity-keys.ts
@@ -8,6 +8,8 @@ import {
   generateJWT,
   jwtExp,
 } from "@walletconnect/did-jwt";
+import { hashMessage } from "@ethersproject/hash";
+import { recoverAddress } from "@ethersproject/transactions";
 import { ICore, IStore } from "@walletconnect/types";
 import { formatMessage, generateRandomBytes32 } from "@walletconnect/utils";
 import axios from "axios";
@@ -42,94 +44,101 @@ export class IdentityKeys implements IIdentityKeys {
     await this.identityKeys.init();
   };
 
-  private generateIdentityKey = async (accountId: string) => {
-    const privateKey = ed25519.utils.randomPrivateKey();
-    const publicKey = await ed25519.getPublicKey(privateKey);
-
-    const pubKeyHex = ed25519.utils.bytesToHex(publicKey).toLowerCase();
-    const privKeyHex = ed25519.utils.bytesToHex(privateKey).toLowerCase();
-
-    return {
-      pubKeyHex,
-      persist: async () => {
-        // Deferring persistence to caller to only persist after success
-        // of signing and registering full cacao on keyserver
-        await this.core.crypto.keychain.set(pubKeyHex, privKeyHex);
-        await this.identityKeys.set(accountId, {
-          identityKeyPriv: privKeyHex,
-          identityKeyPub: pubKeyHex,
-          accountId,
-        });
-      },
-    };
-  };
-
   public generateIdAuth = async (accountId: string, payload: JwtPayload) => {
     const { identityKeyPub, identityKeyPriv } = this.identityKeys.get(accountId);
 
     return generateJWT([identityKeyPub, identityKeyPriv], payload);
   };
 
-  public async registerIdentity({
-    accountId,
-    onSign,
+  public isRegistered(account: string) {
+    return this.identityKeys.keys.includes(account);
+  }
+
+  public async prepareRegistration({
     domain,
+    accountId,
     statement,
+  }: {
+    domain: string;
+    statement?: string;
+    accountId: string;
+  }) {
+    const { privateKey, pubKeyHex } = await this.generateIdentityKey();
+
+    const cacaoPayload = {
+      aud: encodeEd25519Key(pubKeyHex),
+      statement,
+      domain,
+      iss: composeDidPkh(accountId),
+      nonce: generateRandomBytes32(),
+      iat: new Date().toISOString(),
+      version: "1",
+      resources: [this.keyserverUrl],
+    };
+
+    return {
+      message: formatMessage(cacaoPayload, composeDidPkh(accountId)),
+      registerParams: {
+        cacaoPayload,
+        privateIdentityKey: privateKey,
+      },
+    };
+  }
+
+  public async registerIdentity({
+    registerParams,
+    signature,
   }: RegisterIdentityParams): Promise<string> {
-    if (this.identityKeys.keys.includes(accountId)) {
+    const accountId = registerParams.cacaoPayload.iss.split(":").slice(-3).join(":");
+
+    if (this.isRegistered(accountId)) {
       const storedKeyPair = this.identityKeys.get(accountId);
       return storedKeyPair.identityKeyPub;
     } else {
       try {
-        const { pubKeyHex, persist } = await this.generateIdentityKey(accountId);
+        const message = formatMessage(registerParams.cacaoPayload, registerParams.cacaoPayload.iss);
+
+        if (!signature) {
+          throw new Error(`Provided an invalid signature. Expected a string but got: ${signature}`);
+        }
 
-        const didKey = encodeEd25519Key(pubKeyHex);
+        const recoveredAddress = recoverAddress(hashMessage(message), signature);
+        const signatureValid =
+          recoveredAddress.toLowerCase() === accountId.split(":").pop()!.toLowerCase();
+
+        if (!signatureValid) {
+          throw new Error(`Provided an invalid signature. Signature ${signature} by account
+            ${accountId} is not a valid signature for message ${message}`);
+        }
+
+        const url = `${this.keyserverUrl}/identity`;
 
         const cacao: Cacao = {
           h: {
             t: "eip4361",
           },
-          p: {
-            aud: didKey,
-            statement,
-            domain,
-            iss: composeDidPkh(accountId),
-            nonce: generateRandomBytes32(),
-            iat: new Date().toISOString(),
-            version: "1",
-            resources: [this.keyserverUrl],
-          },
+          p: registerParams.cacaoPayload,
           s: {
             t: "eip191",
-            s: "",
+            s: signature,
           },
         };
 
-        const cacaoMessage = formatMessage(cacao.p, composeDidPkh(accountId));
-
-        const signature = await onSign(cacaoMessage);
-
-        if (!signature) {
-          throw new Error(`Provided an invalid signature. Expected a string but got: ${signature}`);
-        }
-
-        const url = `${this.keyserverUrl}/identity`;
-
         try {
-          await axios.post(url, {
-            cacao: {
-              ...cacao,
-              s: {
-                ...cacao.s,
-                s: signature,
-              },
-            },
-          });
+          await axios.post(url, { cacao });
         } catch (e) {
           throw new Error(`Failed to register on keyserver: ${e}`);
         }
 
-        await persist();
+        // Persist keys only after successful registration
+        const { pubKeyHex, privKeyHex } = await this.getKeyData(registerParams.privateIdentityKey);
+
+        await this.core.crypto.keychain.set(pubKeyHex, privKeyHex);
+        await this.identityKeys.set(accountId, {
+          identityKeyPriv: privKeyHex,
+          identityKeyPub: pubKeyHex,
+          accountId,
+        });
 
         return pubKeyHex;
       } catch (error) {
@@ -197,4 +206,27 @@ export class IdentityKeys implements IIdentityKeys {
   public async hasIdentity({ account }: GetIdentityParams): Promise<boolean> {
     return this.identityKeys.keys.includes(account);
   }
+
+  // --------------------------- Private Helpers -----------------------------//
+
+  private generateIdentityKey = () => {
+    const privateKey = ed25519.utils.randomPrivateKey();
+
+    return this.getKeyData(privateKey);
+  };
+
+  private getKeyHex = (key: Uint8Array) => {
+    return ed25519.utils.bytesToHex(key).toLowerCase();
+  };
+
+  private getKeyData = async (privateKey: Uint8Array) => {
+    const publicKey = await ed25519.getPublicKey(privateKey);
+
+    return {
+      publicKey,
+      privateKey,
+      pubKeyHex: this.getKeyHex(publicKey),
+      privKeyHex: this.getKeyHex(privateKey),
+    };
+  };
 }
diff --git a/misc/identity-keys/src/types.ts b/misc/identity-keys/src/types.ts
@@ -1,11 +1,12 @@
-import { Cacao } from "@walletconnect/cacao";
+import { CacaoPayload, Cacao } from "@walletconnect/cacao";
 import { JwtPayload } from "@walletconnect/did-jwt";
 
 export interface RegisterIdentityParams {
-  accountId: string;
-  onSign: (message: string) => Promise<string | undefined>;
-  domain: string;
-  statement: string;
+  registerParams: {
+    cacaoPayload: CacaoPayload;
+    privateIdentityKey: Uint8Array;
+  };
+  signature: string;
 }
 
 export interface ResolveIdentityParams {
diff --git a/misc/identity-keys/test/identity-keys.test.ts b/misc/identity-keys/test/identity-keys.test.ts
@@ -15,15 +15,12 @@ describe("@walletconnect/identity-keys", () => {
 
   let wallet: Wallet;
   let accountId: string;
-  let onSign: (m: string) => Promise<string>;
   let core: ICore;
   let identityKeys: IdentityKeys;
 
   beforeEach(async () => {
     wallet = Wallet.createRandom();
     accountId = `eip155:1:${wallet.address}`;
-    onSign = (m) => wallet.signMessage(m);
-
     core = new Core({ projectId: PROJECT_ID });
 
     identityKeys = identityKeys = new IdentityKeys(core, DEFAULT_KEYSERVER_URL);
@@ -33,13 +30,19 @@ describe("@walletconnect/identity-keys", () => {
   });
 
   it("registers on keyserver", async () => {
-    const identity = await identityKeys.registerIdentity({
+    const { message, registerParams } = await identityKeys.prepareRegistration({
       accountId,
       statement,
-      onSign,
       domain,
     });
 
+    const signature = await wallet.signMessage(message);
+
+    const identity = await identityKeys.registerIdentity({
+      registerParams,
+      signature,
+    });
+
     const encodedIdentity = encodeEd25519Key(identity).split(":")[2];
 
     const fetchUrl = `${DEFAULT_KEYSERVER_URL}/identity?publicKey=${encodedIdentity}`;
@@ -50,34 +53,45 @@ describe("@walletconnect/identity-keys", () => {
   });
 
   it("does not persist identity keys that failed to register", async () => {
+    const { registerParams } = await identityKeys.prepareRegistration({
+      accountId,
+      statement,
+      domain,
+    });
+
     // rejectedWith & rejected are not supported on this version of chai
     let failMessage = "";
+
+    const signature = await wallet.signMessage("otherMessage");
     await identityKeys
       .registerIdentity({
-        accountId,
-        statement,
-        onSign: () => Promise.resolve("badSignature"),
-        domain,
+        registerParams,
+        signature,
       })
       .catch((err) => (failMessage = err.message));
 
-    expect(failMessage).eq(
-      `Failed to register on keyserver: AxiosError: Request failed with status code 400`,
+    expect(failMessage).match(
+      new RegExp(`Provided an invalid signature. Signature ${signature} by account
+            ${accountId} is not a valid signature for message .*`),
     );
 
     const keys = identityKeys.identityKeys.getAll();
     expect(keys.length).eq(0);
   });
 
   it("prevents registering with empty signatures", async () => {
+    const { registerParams } = await identityKeys.prepareRegistration({
+      accountId,
+      statement,
+      domain,
+    });
+
     // rejectedWith & rejected are not supported on this version of chai
     let failMessage = "";
     await identityKeys
       .registerIdentity({
-        accountId,
-        statement,
-        onSign: () => Promise.resolve(""),
-        domain,
+        registerParams,
+        signature: "",
       })
       .catch((err) => (failMessage = err.message));
 
diff --git a/misc/identity-keys/tsconfig.json b/misc/identity-keys/tsconfig.json
@@ -4,6 +4,7 @@
   "compilerOptions": {
     "rootDir": "src",
     "outDir": "./dist/types",
+    "ignoreDeprecations": "5.0",
     "emitDeclarationOnly": true
   }
 }
diff --git a/package-lock.json b/package-lock.json

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@`
`4`	`4`	`"compilerOptions": {`
`5`	`5`	`"rootDir": "src",`
`6`	`6`	`"outDir": "./dist/types",`
	`7`	`+ "ignoreDeprecations": "5.0",`
`7`	`8`	`"emitDeclarationOnly": true`
`8`	`9`	`}`
`9`	`10`	`}`