Repository navigation
Commit 205184f
authored
feat(win): portable install location picker (rebased on i18n, review fixes folded in) (#8)
Lets Windows users choose where the portable Codex build installs, persisted
across uninstalls. The backend gains a validated `install_root` (migrated from
old settings) used across plan/stage/status/adopt/perform/uninstall; the UI adds
a native folder picker (invoked through a Rust command), a Settings location row,
and a fresh-install location sheet.
Rebased onto main after the i18n PR (#7) merged, so the previously duplicated
install-location strings now come from #7 only. The unused npm
@tauri-apps/plugin-dialog dependency is dropped — the picker goes through a Rust
command and nothing imports the JS binding (the Rust tauri-plugin-dialog stays).
Review fixes folded in:
- validate_install_root_path no longer creates the target directory to probe it
(it probes the nearest existing ancestor), so selecting/resetting a location
no longer leaves folders on disk; the dir is created at install time.
- the chosen install root is persisted only AFTER a successful install, and the
Browse flow is one-shot, so a failed/cancelled attempt keeps the saved default.
- a managed portable build is gracefully closed before MSIX sideload, instead of
potentially being left running after the switch.
- uninstall and status use is_managed_build (path + build) like the macOS path,
not path-only is_managed — safer now that the install root is user-configurable
and paths can be reused.1 parent 996fe15 commit 205184f
16 files changed
Lines changed: 919 additions & 54 deletions
File tree
- src-tauri
- capabilities
- src
- app
- src
- app
- views
- services
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| 31 | + | |
31 | 32 | | |
32 | 33 | | |
33 | 34 | | |
| 35 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
10 | 11 | | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
14 | | - | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
7 | 8 | | |
| 9 | + | |
| 10 | + | |
8 | 11 | | |
9 | 12 | | |
10 | 13 | | |
| |||
25 | 28 | | |
26 | 29 | | |
27 | 30 | | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
28 | 35 | | |
29 | 36 | | |
30 | 37 | | |
| |||
35 | 42 | | |
36 | 43 | | |
37 | 44 | | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
38 | 49 | | |
39 | 50 | | |
40 | 51 | | |
| |||
45 | 56 | | |
46 | 57 | | |
47 | 58 | | |
| 59 | + | |
48 | 60 | | |
49 | 61 | | |
50 | 62 | | |
| |||
55 | 67 | | |
56 | 68 | | |
57 | 69 | | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
58 | 84 | | |
59 | 85 | | |
60 | 86 | | |
| |||
63 | 89 | | |
64 | 90 | | |
65 | 91 | | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
| 92 | + | |
70 | 93 | | |
71 | 94 | | |
72 | 95 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
179 | 179 | | |
180 | 180 | | |
181 | 181 | | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
182 | 189 | | |
183 | 190 | | |
184 | 191 | | |
| |||
426 | 433 | | |
427 | 434 | | |
428 | 435 | | |
429 | | - | |
| 436 | + | |
| 437 | + | |
430 | 438 | | |
431 | 439 | | |
432 | 440 | | |
| |||
470 | 478 | | |
471 | 479 | | |
472 | 480 | | |
473 | | - | |
474 | | - | |
475 | | - | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
476 | 486 | | |
477 | 487 | | |
478 | 488 | | |
| |||
503 | 513 | | |
504 | 514 | | |
505 | 515 | | |
| 516 | + | |
| 517 | + | |
| 518 | + | |
| 519 | + | |
| 520 | + | |
| 521 | + | |
| 522 | + | |
| 523 | + | |
| 524 | + | |
| 525 | + | |
506 | 526 | | |
507 | 527 | | |
508 | 528 | | |
| |||
551 | 571 | | |
552 | 572 | | |
553 | 573 | | |
| 574 | + | |
| 575 | + | |
| 576 | + | |
| 577 | + | |
| 578 | + | |
554 | 579 | | |
555 | 580 | | |
556 | | - | |
| 581 | + | |
557 | 582 | | |
558 | 583 | | |
559 | 584 | | |
| |||
562 | 587 | | |
563 | 588 | | |
564 | 589 | | |
565 | | - | |
| 590 | + | |
566 | 591 | | |
567 | 592 | | |
568 | 593 | | |
| |||
608 | 633 | | |
609 | 634 | | |
610 | 635 | | |
611 | | - | |
| 636 | + | |
| 637 | + | |
| 638 | + | |
| 639 | + | |
612 | 640 | | |
613 | 641 | | |
614 | 642 | | |
| |||
654 | 682 | | |
655 | 683 | | |
656 | 684 | | |
657 | | - | |
| 685 | + | |
| 686 | + | |
| 687 | + | |
| 688 | + | |
| 689 | + | |
658 | 690 | | |
659 | 691 | | |
660 | 692 | | |
| |||
702 | 734 | | |
703 | 735 | | |
704 | 736 | | |
705 | | - | |
| 737 | + | |
706 | 738 | | |
707 | 739 | | |
708 | 740 | | |
| |||
0 commit comments