BUGFIX: Exclude strong name in SignatureComparer.GetHashCode(AssemblyDescriptor) when IgnoreStrongNames flag is set

Author: Washi1337

src/AsmResolver.DotNet/Signatures/SignatureComparer.ResolutionScope.cs

@@ -83,8 +83,11 @@ public virtual int GetHashCode(AssemblyDescriptor obj)
                 if (!AcceptNewerAssemblyVersionNumbers && !AcceptOlderAssemblyVersionNumbers)
                     hashCode = (hashCode * 397) ^ obj.Version.GetHashCode();
 
-                byte[]? publicKeyToken = obj.GetPublicKeyToken();
-                hashCode = (hashCode * 397) ^ (publicKeyToken is not null ? GetHashCode(publicKeyToken) : 0);
+                if (!IgnoreStrongNames)
+                {
+                    byte[]? publicKeyToken = obj.GetPublicKeyToken();
+                    hashCode = (hashCode * 397) ^ (publicKeyToken is not null ? GetHashCode(publicKeyToken) : 0);
+                }
 
                 return hashCode;
             }

test/AsmResolver.DotNet.Tests/Signatures/SignatureComparerTest.cs

@@ -201,10 +201,11 @@ public void AssemblyHashCodeStrict()
         {
             var assembly1 = new AssemblyReference("SomeAssembly", new Version(1, 2, 3, 4));
             var assembly2 = new AssemblyReference("SomeAssembly", new Version(1, 2, 3, 4));
+            var assembly3 = new AssemblyReference("SomeAssembly", new Version(1, 2, 3, 4), false, [1, 2, 3, 4, 5, 6, 7, 8]);
 
-            Assert.Equal(
-                _comparer.GetHashCode((AssemblyDescriptor) assembly1),
-                _comparer.GetHashCode((AssemblyDescriptor) assembly2));
+            var comparer = new SignatureComparer();
+            Assert.Equal(comparer.GetHashCode(assembly1), _comparer.GetHashCode(assembly2));
+            Assert.NotEqual(comparer.GetHashCode(assembly1), _comparer.GetHashCode(assembly3));
         }
 
         [Fact]
@@ -214,9 +215,29 @@ public void AssemblyHashCodeVersionAgnostic()
             var assembly2 = new AssemblyReference("SomeAssembly", new Version(5, 6, 7, 8));
 
             var comparer = new SignatureComparer(SignatureComparisonFlags.VersionAgnostic);
+            Assert.Equal(comparer.GetHashCode(assembly1), comparer.GetHashCode(assembly2));
+        }
+
+        [Fact]
+        public void AssemblyHashCodeIgnoreStrongNames()
+        {
+            var assembly1 = new AssemblyReference(
+                "SomeAssembly",
+                new Version(1, 2, 3, 4),
+                false,
+                [1, 2, 3, 4, 5, 6, 7, 8]
+            );
+
+            var assembly2 = new AssemblyReference(
+                "SomeAssembly",
+                new Version(1, 2, 3, 4)
+            );
+
+            var comparer = new SignatureComparer(SignatureComparisonFlags.IgnoreStrongNames);
             Assert.Equal(
                 comparer.GetHashCode((AssemblyDescriptor) assembly1),
-                comparer.GetHashCode((AssemblyDescriptor) assembly2));
+                comparer.GetHashCode((AssemblyDescriptor) assembly2)
+            );
         }
 
         [Fact]