Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: midi output objects don't accept lists #206

Open
dromer opened this issue Oct 13, 2024 · 1 comment
Open

Bug: midi output objects don't accept lists #206

dromer opened this issue Oct 13, 2024 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@dromer
Copy link
Collaborator

dromer commented Oct 13, 2024

The output object implementations assume that all inlets are being used.

When a user sends a list to the object it skips the step of adjusting midi channels from 1-based to 0-based counting:

2024-10-13_09-48

@dromer dromer added the bug Something isn't working label Oct 13, 2024
@dromer dromer added the good first issue Good for newcomers label Oct 13, 2024
@dromer
Copy link
Collaborator Author

dromer commented Oct 13, 2024

We could've really used some midi-out tests to catch these sort of bugs :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Status: Todo
Development

No branches or pull requests

1 participant