diff --git a/docs/Deep Dive/GitHub/PullRequests.md b/docs/Deep Dive/GitHub/PullRequests.md index de7830ad..56d1b88b 100644 --- a/docs/Deep Dive/GitHub/PullRequests.md +++ b/docs/Deep Dive/GitHub/PullRequests.md @@ -32,7 +32,7 @@ Commits generally require the approval of a [reviewer](https://webkit.org/team/# ## Landing -Only repository administrators have direct commit access, and this is reserved for repairing infrastructure issues. Pull requests should be landed through the [Merge-Queues](/Getting Started/ContributingCode#merge-queues), which is achieved by applying the [`safe-merge-queue`](https://github.com/WebKit/WebKit/labels?q=safe-merge-queue), [`merge-queue`](https://github.com/WebKit/WebKit/labels?q=merge-queue), or [`unsafe-merge-queue`](https://github.com/WebKit/WebKit/labels?q=unfsafe-merge-queue) label to your pull request. +Only repository administrators have direct commit access, and this is reserved for repairing infrastructure issues. Pull requests should be landed through the [Merge-Queues](/Getting Started/ContributingCode#merge-queues), which is achieved by applying the [`safe-merge-queue`](https://github.com/WebKit/WebKit/labels?q=safe-merge-queue), [`merge-queue`](https://github.com/WebKit/WebKit/labels?q=merge-queue), or [`unsafe-merge-queue`](https://github.com/WebKit/WebKit/labels?q=unfsafe-merge-queue) label to your pull request. You need to add yourself in the contributors.json file so you can set the label. Each queue makes sure a change is reviewed by adding the name of all [reviewers](https://webkit.org/team/#reviewers) who have approved a pull request to the commit message. It will then check the commit message for `Reviewed by`. diff --git a/docs/Getting Started/ContributingCode.md b/docs/Getting Started/ContributingCode.md index 935572df..2036577f 100644 --- a/docs/Getting Started/ContributingCode.md +++ b/docs/Getting Started/ContributingCode.md @@ -56,7 +56,7 @@ git webkit pr ### Merge Queues -If you have [committer](https://webkit.org/team/#committers) rights, you can land a pull request by adding the [`safe-merge-queue`](https://github.com/WebKit/WebKit/labels?q=safe-merge-queue), [`merge-queue`](https://github.com/WebKit/WebKit/labels?q=merge-queue), or [`unsafe-merge-queue`](https://github.com/WebKit/WebKit/labels?q=unsafe-merge-queue) label to your pull request. These labels will put your pull request into [Safe-Merge-Queue](https://ews-build.webkit.org/#/builders/Safe-Merge-Queue), [Merge-Queue](https://ews-build.webkit.org/#/builders/Merge-Queue), and [Unsafe-Merge-Queue](https://ews-build.webkit.org/#/builders/Unsafe-Merge-Queue), respectively, which will commit your pull request to the WebKit repository. If you are not a committer, you can use [`request-merge-queue`](https://github.com/WebKit/WebKit/labels?q=request-merge-queue) so whoever reviews the patch can add it to the queue. +If you have [committer](https://webkit.org/team/#committers) rights, you can land a pull request by adding the [`safe-merge-queue`](https://github.com/WebKit/WebKit/labels?q=safe-merge-queue), [`merge-queue`](https://github.com/WebKit/WebKit/labels?q=merge-queue), or [`unsafe-merge-queue`](https://github.com/WebKit/WebKit/labels?q=unsafe-merge-queue) label to your pull request. These labels will put your pull request into [Safe-Merge-Queue](https://ews-build.webkit.org/#/builders/Safe-Merge-Queue), [Merge-Queue](https://ews-build.webkit.org/#/builders/Merge-Queue), and [Unsafe-Merge-Queue](https://ews-build.webkit.org/#/builders/Unsafe-Merge-Queue), respectively, which will commit your pull request to the WebKit repository. If you are not a committer, you can use [`request-merge-queue`](https://github.com/WebKit/WebKit/labels?q=request-merge-queue) so whoever reviews the patch can add it to the queue. You have to add yourself in the contributors.json file first so you can set the label. Each queue runs a style-check and inserts reviewer information into the commit message and modified change logs. They check that a pull request has been reviewed by checking the commit message before landing the change.