We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hello!
Ive been looking through your nice library and I found some puzzling things about the reportConstraints function.
reportConstraints
It seems like there might be a typo here where .lenght should be .length
.lenght
.length
physics-module-ammonext/bundle-worker/physics-module.js
Line 3139 in 5f58d67
It also seems as if it was not fixed for quite a while.
.ta
The .ta attribute is set in the addConstraint function for the slider, conetwist, and dof types.
addConstraint
slider
conetwist
dof
Lines 2527 to 2528 in 5f58d67
The .ta attribute is only used in the reportConstraints function for ALL constraints regardless of type.
Lines 3141 to 3158 in 5f58d67
Therefore, if you create a constraint that does not set the .ta attribute, you will get an error when this function is run:
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Hello!
Ive been looking through your nice library and I found some puzzling things about the
reportConstraints
function.1. Typo
It seems like there might be a typo here where
.lenght
should be.length
physics-module-ammonext/bundle-worker/physics-module.js
Line 3139 in 5f58d67
It also seems as if it was not fixed for quite a while.
2.
.ta
attribute is defined conditionallyThe
.ta
attribute is set in theaddConstraint
function for theslider
,conetwist
, anddof
types.physics-module-ammonext/bundle-worker/physics-module.js
Lines 2527 to 2528 in 5f58d67
The
.ta
attribute is only used in thereportConstraints
function for ALL constraints regardless of type.physics-module-ammonext/bundle-worker/physics-module.js
Lines 3141 to 3158 in 5f58d67
Therefore, if you create a constraint that does not set the
.ta
attribute, you will get an error when this function is run:The text was updated successfully, but these errors were encountered: