Skip to content

[Suggestion] Use Minecraft biome tags and c tags for better mod compat #4

@TelepathicGrunt

Description

@TelepathicGrunt

I saw in 1.21.1 NeoForge that your mod hardcodes biomes for the structure to spawn in. Like here:

https://github.com/WightofShadows/Wabi_Sabi_Structures/blob/1.21/data/wabi_sabi_structures/tags/worldgen/biome/has_structure/xocolatl_farm.json

I wanted to point out that if you have your has_structure tags use the minecraft and c biome tags, your structures will spawn in more modded biomes without needing explicit compat for each biome. For example, using #c:is_jungle as a require-false tag entry in your tag, your structure will spawn in all Overworld modded jungle biomes in that tag.

minecraft namespace biome tags:
https://github.com/misode/mcmeta/tree/b7e7f5282f9cc2ca1bd01e9a4911beab4725cb4b/data/minecraft/tags/worldgen/biome

c namespace biome tags:
https://github.com/neoforged/NeoForge/tree/1.21.1/src/generated/resources/data/c/tags/worldgen/biome

Metadata

Metadata

Assignees

Labels

compatibilityPlaying nicely with others

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions