Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ProtoBuf mapping.json #1236

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

StefH
Copy link
Collaborator

@StefH StefH commented Jan 9, 2025

close #1233

@StefH StefH added the bug label Jan 9, 2025
@StefH StefH self-assigned this Jan 9, 2025
@StefH StefH changed the title Fix ProtoBuf Mappings Fix ProtoBuf mapping.json Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 63.63636% with 28 lines in your changes missing coverage. Please review.

Project coverage is 32.88%. Comparing base (9c94324) to head (cb14de1).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/WireMock.Net/Util/PortUtils.cs 64.51% 11 Missing ⚠️
src/WireMock.Net/RequestBuilders/Request.cs 60.00% 6 Missing ⚠️
src/WireMock.Net/Util/ProtoDefinitionHelper.cs 66.66% 6 Missing ⚠️
...eMock.Net/ResponseBuilders/Response.WithHeaders.cs 0.00% 3 Missing ⚠️
...t/Matchers/Helpers/BodyDataMatchScoreCalculator.cs 75.00% 1 Missing ⚠️
src/WireMock.Net/ResponseBuilders/Response.cs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1236      +/-   ##
==========================================
- Coverage   34.43%   32.88%   -1.56%     
==========================================
  Files         203      204       +1     
  Lines       33320    36827    +3507     
==========================================
+ Hits        11473    12109     +636     
- Misses      21331    24127    +2796     
- Partials      516      591      +75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GRPC mappings are not created correctly when created through Admin API
1 participant