Inserter: Remove inappropriate icon from 'no results' message

[afercia]

Description

Splitting this out from #67731 (comment)

When searching for blocks in the main inserter and there are no results, a No results found message is shown together with an icon that (I guess) was originally intended to represent a block.

However, the same 'block' icon is shown when there are no results for patterns and media. Screenshot:

In this cases, the icon is inappropriate and I'd tend to think it's just a leftover that doesn't add great value in the first place. I'd like to suggest to remove it entirely.

Step-by-step reproduction instructions

• Open the main inserter.
• Search for a non-existing block.
• Observe the 'no result' message shows an icon.
• Repeat for Patterns.
• CLick the 'Media' tab and observe that while loading the message and icon are shown.
• Search for a non-existing media and observe the message and icon.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

• Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

• Yes

Please confirm which theme type you used for testing.

• Block
• Classic
• Hybrid (e.g. classic with theme.json)
• Not sure

[hanneslsm]

The same design is also used in the Quick Inserter
https://wordpress.github.io/gutenberg/?path=/docs/blockeditor-inserter--docs

[afercia]

Nice catch @hanneslsm. I'd suggest to search for all the occurrences of this icon usage e.g. icon={ blockDefault } and remove it when it's not appropriate.
One more usage in the deprecated core/post-comment block and I think we can ignore it.

Worth noting that this icon is used also in the Widgets page, in the widget area settings panel:

to me, this is one more good reason to remove the icon from all the 'no results' patterns.

I'm pretty sure design would agree that icons make only sense when used for an unique concept. They shouldn't be used to communicate different concepts or represent different features.