Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Toolbar should ideally be displayed over spacing highlight #68711

Open
3 of 6 tasks
yogeshbhutkar opened this issue Jan 16, 2025 · 5 comments
Open
3 of 6 tasks

Block Toolbar should ideally be displayed over spacing highlight #68711

yogeshbhutkar opened this issue Jan 16, 2025 · 5 comments
Labels
[Package] Block editor /packages/block-editor [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Bug An existing feature does not function as intended

Comments

@yogeshbhutkar
Copy link
Contributor

yogeshbhutkar commented Jan 16, 2025

Description

When adding spacing (e.g., margin or padding) to a block, a blue highlight appears to indicate the amount of spacing applied. However, this highlight overlaps the Block Toolbar, making the toolbar options harder to see. The Block Toolbar should be displayed above the spacing highlight to ensure its options remain fully visible when adjusting block spacing.

If this issue seems like a duplicate of some other issue or is an intended behavior, please feel free to close this one.

Step-by-step reproduction instructions

  1. Navigate to the post edit page.
  2. Create any Block.
  3. Try changing the Block's margin.
  4. Confirm the spacing highlight overlaps with the Toolbar.

Screenshots, screen recording, code snippet

Image

Environment info

  • WordPress Version: 6.8-alpha-59361
  • Gutenberg Version: Trunk (74986ed)
  • OS: macOS Sequoia

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes

Please confirm which theme type you used for testing.

  • Block
  • Classic
  • Hybrid (e.g. classic with theme.json)
  • Not sure
@yogeshbhutkar yogeshbhutkar added the [Type] Bug An existing feature does not function as intended label Jan 16, 2025
@Mamaduka Mamaduka added [Package] Block editor /packages/block-editor [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later labels Jan 16, 2025
@Mamaduka
Copy link
Member

It is worth checking the original PRs for this feature; this could be the intentional or known effect that should be ignored.

Labeling this as a low-priority bug since users still get the proper visual feedback.

@Mayank-Tripathi32
Copy link
Contributor

I personally believe this might have been intentional, as the margin highlight appears specifically when adjusting the margin. It has a higher priority, so it is designed to be visible above the toolbar. I will look up the previous issues to see if it has been discussed before.

@stokesman
Copy link
Contributor

Intentional or not it feels unpolished to me. I'm not sure it’d be much improved by having the block toolbar in front. I wonder if it might be better to hide the block toolbar while the visualizer is visible.

@Mayank-Tripathi32
Copy link
Contributor

Intentional or not it feels unpolished to me. I'm not sure it’d be much improved by having the block toolbar in front. I wonder if it might be better to hide the block toolbar while the visualizer is visible.

Yea, that might be better actually. We can make it so that while highlight is showing the toolbar is disabled.

@yogeshbhutkar
Copy link
Contributor Author

it might be better to hide the block toolbar while the visualizer is visible.

It makes sense, we won't use the toolbar when setting up the spacing. We should probably wait for design feedback on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Block editor /packages/block-editor [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants