Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Details block: Remove the hard-coded empty array in allowedFormats #68738

Open
shimotmk opened this issue Jan 17, 2025 · 3 comments · May be fixed by #68741
Open

Details block: Remove the hard-coded empty array in allowedFormats #68738

shimotmk opened this issue Jan 17, 2025 · 3 comments · May be fixed by #68741
Labels
[Block] Details Affects the Details Block - used to display content which can be shown/hidden [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@shimotmk
Copy link
Contributor

What problem does this address?

The summary tag of the Details block has an empty array hard-coded in allowedFormats.

If allowedFormats is set, customization from the plugin is not possible.

Please add a hook or remove allowFormat so that Format can be used.

similar: #67559

I was unable to confirm the reason, but all formats were disabled in allowFormat from the beginning when the block was added.

#45055
#49808

What is your proposed solution?

Remove the allowedFormats={ [] }

Labels

[Block] Details
[Type] Enhancement

@shimotmk shimotmk added the [Type] Enhancement A suggestion for improvement. label Jan 17, 2025
@Mamaduka Mamaduka added the [Block] Details Affects the Details Block - used to display content which can be shown/hidden label Jan 17, 2025
@im3dabasia im3dabasia linked a pull request Jan 17, 2025 that will close this issue
@Mamaduka
Copy link
Member

@shimotmk, it would help if we could track down the reason for the restriction

I think @carolinan might have some context.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 17, 2025
@carolinan
Copy link
Contributor

carolinan commented Jan 17, 2025

I don't recall exactly, but it is most likely because leaving it enabled increases the complexity of the block.
There is one case where the block will not be accessible, and that is if the inline image is used alone, since then there is no text-only summary.

It depends on what you are trying to do, because the block already has styling options in the sidebar.
If you need to also change withoutInteractiveFormatting then more keyboard and screen-reader testing is needed.

@Mamaduka
Copy link
Member

The interactive formatting should stay disabled; the summary element is interactive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Details Affects the Details Block - used to display content which can be shown/hidden [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants