Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Details: Enable all non-interactive formats #68741

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Details: Enable all non-interactive formats #68741

wants to merge 1 commit into from

Conversation

im3dabasia
Copy link
Contributor

@im3dabasia im3dabasia commented Jan 17, 2025 •
edited
Loading

Closes: #68738

What?

PR removes hardcoded allowlist for RichText formats in the Details blocks. Now, all non-interactive formats are allowed within these blocks.

This changes matches the behaviour of the button, navigation block

Why?

Allows consumers to register custom formats that can be used with details blocks.

Testing instructions

  1. Open a post or page.
  2. Insert a details block.
  3. Confirm that all non-interactive formats are visible for the details block.

Screenshots or screencast

image

@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. [Block] Details Affects the Details Block - used to display content which can be shown/hidden labels Jan 17, 2025
@im3dabasia im3dabasia marked this pull request as ready for review January 17, 2025 11:22
@github-actions GitHub Actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: im3dabasia <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: shimotmk <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
[Block] Details Affects the Details Block - used to display content which can be shown/hidden [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Details block: Remove the hard-coded empty array in allowedFormats
2 participants
@im3dabasia @Mamaduka