Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default background color and typography from the theme are inherited on editor #68743

Open
4 of 6 tasks
ricklabsdotn8 opened this issue Jan 17, 2025 · 3 comments
Open
4 of 6 tasks
Labels
[Type] Bug An existing feature does not function as intended

Comments

@ricklabsdotn8
Copy link

ricklabsdotn8 commented Jan 17, 2025

Description

The default background color and typography of the theme are inherited as the background of the editor. This results in an inaccurate preview, when the single-post and single-page templates are changed

Step-by-step reproduction instructions

Block themes

  1. Activate a block theme, e.g. Twenty Twenty Four
  2. Next, go to theme styles (Appearance → Editor → Styles)
  3. Select a dark palette or style
  4. Then, edit a post.

Classic themes

  1. Choose a classic theme with a dark or gray background color, e.g. Storefront
  2. Activate the theme
  3. Then, edit a post

In both cases, the editor uses the default background color. This affects the UX in the following manner:

It is not always accurate to use the default background color and typography on the editor because the single-post and single-page templates can be customized.

When these templates are changed, the preview on the editor will no longer be the same as the actual preview.

For example - https://share.zight.com/12udAgLl

This leads to confusion on the user's part, and sets the wrong expectations, compared when the editor used a dark text color against a white background

Screenshots, screen recording, code snippet

https://share.zight.com/12udAgLl

Environment info

  • WP 6.7.1, Gutenberg 20.0.0, Twenty Twenty Four, Storefront

  • All browsers

  • All OS

  • Atomic

  • Simple

  • dotOrg

  • 9296589-zen

  • 9296087-zen

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes

Please confirm which theme type you used for testing.

  • Block
  • Classic
  • Hybrid (e.g. classic with theme.json)
  • Not sure
@ricklabsdotn8 ricklabsdotn8 added the [Type] Bug An existing feature does not function as intended label Jan 17, 2025
@ricklabsdotn8 ricklabsdotn8 changed the title Default theme background color and typography is inherited as background Default background color and typography from the theme are inherited on editor Jan 17, 2025
@hanneslsm
Copy link

hanneslsm commented Jan 17, 2025

It looks like you're editing the post in the page editor, not site editor, where on default the template is not shown.
From what I can tell, all is on purpose.
Does the issue also occur, when you display the template? (Inspector on the right → Post → Template → Show template)

@ricklabsdotn8
Copy link
Author

It looks like you're editing the post in the page editor, not site editor, where on default the template is not shown. From what I can tell, all is on purpose. Does the issue also occur, when you display the template? (Inspector on the right → Post → Template → Show template)

  • It does show the proper template. IMO, it is still a radical change which leaves some users confused and adds to what they need to think about.

@hanneslsm
Copy link

In the newest Gutenberg Version you can toggle the preview also in the View Settings.
This should help clarifying any confusions.

#66429

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants