{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":75645659,"defaultBranch":"trunk","name":"wordpress-develop","ownerLogin":"WordPress","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2016-12-05T16:41:44.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/276006?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1726800619.0","currentOid":""},"activityList":{"items":[{"before":null,"after":"fb30a52b440af0bf747b4da6e2c291f675e8baa1","ref":"refs/heads/dependabot/github_actions/github-actions-b015093312","pushedAt":"2024-09-20T02:50:19.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"},"commit":{"message":"Bump the github-actions group across 1 directory with 3 updates\n\nBumps the github-actions group with 3 updates in the / directory: [actions/setup-node](https://github.com/actions/setup-node), [actions/upload-artifact](https://github.com/actions/upload-artifact) and [slackapi/slack-github-action](https://github.com/slackapi/slack-github-action).\n\n\nUpdates `actions/setup-node` from 4.0.3 to 4.0.4\n- [Release notes](https://github.com/actions/setup-node/releases)\n- [Commits](https://github.com/actions/setup-node/compare/1e60f620b9541d16bece96c5465dc8ee9832be0b...0a44ba7841725637a19e28fa30b79a866c81b0a6)\n\nUpdates `actions/upload-artifact` from 4.3.4 to 4.4.0\n- [Release notes](https://github.com/actions/upload-artifact/releases)\n- [Commits](https://github.com/actions/upload-artifact/compare/0b2256b8c012f0828dc542b3febcab082c67f72b...50769540e7f4bd5e21e526ee35c689e35e0d6874)\n\nUpdates `slackapi/slack-github-action` from 1.26.0 to 1.27.0\n- [Release notes](https://github.com/slackapi/slack-github-action/releases)\n- [Commits](https://github.com/slackapi/slack-github-action/compare/70cd7be8e40a46e8b0eced40b0de447bdb42f68e...37ebaef184d7626c5f204ab8d3baff4262dd30f0)\n\n---\nupdated-dependencies:\n- dependency-name: actions/setup-node\n  dependency-type: direct:production\n  update-type: version-update:semver-patch\n  dependency-group: github-actions\n- dependency-name: actions/upload-artifact\n  dependency-type: direct:production\n  update-type: version-update:semver-minor\n  dependency-group: github-actions\n- dependency-name: slackapi/slack-github-action\n  dependency-type: direct:production\n  update-type: version-update:semver-minor\n  dependency-group: github-actions\n...\n\nSigned-off-by: dependabot[bot] <support@github.com>","shortMessageHtmlLink":"Bump the github-actions group across 1 directory with 3 updates"}},{"before":"1ad25bb1432c788c8084fe832a7f13e646a28b62","after":"35907da95151b45d197102ea4d69e10ad019cab9","ref":"refs/heads/trunk","pushedAt":"2024-09-20T02:06:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pento","name":"Gary Pendergast","path":"/pento","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/352291?s=80&v=4"},"commit":{"message":"Editor: Add plugin template registration API and improve theme overrides for plugin-registered templates\n\nThis commit introduces a new API to allow plugins to easily register block\ntemplates with `wp_register_block_template()` and the\n`WP_Block_Templates_Registry` class, addressing the complexity of hooking into\nmultiple filters. It also ensures plugin-registered templates overridden by\nthemes fall back to the plugin-provided title and description when the theme\ndoesn't define them.\n\nSee https://github.com/WordPress/gutenberg/pull/61577.\nSee https://github.com/WordPress/gutenberg/pull/64610.\n\nFixes #61804.\nProps aljullu, peterwilsoncc, antonvlasenko, azaozz, youknowriad, noisysocks.\n\n\ngit-svn-id: https://develop.svn.wordpress.org/trunk@59073 602fd350-edb4-49c9-b593-d223f7449a82","shortMessageHtmlLink":"Editor: Add plugin template registration API and improve theme overri…"}},{"before":"d46067a77628797897a8c853fabbefc4cc2b1790","after":"1ad25bb1432c788c8084fe832a7f13e646a28b62","ref":"refs/heads/trunk","pushedAt":"2024-09-20T01:54:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pento","name":"Gary Pendergast","path":"/pento","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/352291?s=80&v=4"},"commit":{"message":"Editor: Update packages for 6.7 Beta 1.\n\nSyncs `@wordpress/*` packages to the `wp-6.7` npm tag.\n\nFixes #61906.\nProps peterwilsoncc, gziolo, kevin940726.\n\n\ngit-svn-id: https://develop.svn.wordpress.org/trunk@59072 602fd350-edb4-49c9-b593-d223f7449a82","shortMessageHtmlLink":"Editor: Update packages for 6.7 Beta 1."}},{"before":"951f887f8a874e9c183bb990b0aa767d3ebb835b","after":"d46067a77628797897a8c853fabbefc4cc2b1790","ref":"refs/heads/trunk","pushedAt":"2024-09-20T00:51:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pento","name":"Gary Pendergast","path":"/pento","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/352291?s=80&v=4"},"commit":{"message":"External Libraries: Test registered script versions match package.json.\n\nExpands tests to ensure the version number of packages updated via NPM matches the version number used for registering the script in the script loader.\n\nThis adds tests for (by their registered name in WordPress):\n\n* backbone\n* clipboard\n* hoverIntent\n* hoverintent-js\n* imagesloaded\n* jquery-color\n* jquery-core\n* jquery-form\n* masonry\n* react-jsx-runtime\n* underscore\n* wp-polyfill-dom-rect\n* wp-polyfill-element-closest\n* wp-polyfill-fetch\n* wp-polyfill-formdata\n* wp-polyfill-inert\n* wp-polyfill-node-contains\n* wp-polyfill-object-fit\n* wp-polyfill-url\n\n\nThis expands on the earlier tests introduced for:\n\n* lodash\n* moment\n* react\n* react-dom\n* regenerator-runtime\n\nAn additional test is added to ensure that the data provider for these tests is maintained as libraries are added via package.json.\n\n`@wordpress/*` scripts are excluded from these tests as wp-scripts generates a version number automatically based on the file's contents.\n\nAdditionally, the version of element-closest listed in package.json is updated to use a fixed version rather than a range. This reflects the current practice of WordPress to define the specific version in core. For the avoidance of doubt, this does not affect the version shipped in WordPress.\n\nFollow up to [57185].\n\nProps peterwilsoncc, jorbin.\nFixes #61855.\n\n\ngit-svn-id: https://develop.svn.wordpress.org/trunk@59071 602fd350-edb4-49c9-b593-d223f7449a82","shortMessageHtmlLink":"External Libraries: Test registered script versions match package.json."}},{"before":"1e608149f92886723d7d162df3014c7ba970030e","after":"951f887f8a874e9c183bb990b0aa767d3ebb835b","ref":"refs/heads/trunk","pushedAt":"2024-09-19T20:21:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pento","name":"Gary Pendergast","path":"/pento","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/352291?s=80&v=4"},"commit":{"message":"External Libraries: Skip instanceof check when null in Text_Diff::_check().\n\nOn the first `foreach` loop in Text_Diff::_check()`, `$prevtype` is `null`. As `instanceof` requires the class name term to be an object or string, a fatal error is thrown:\n\n>Fatal error: Uncaught Error: Class name must be a valid object or a string on line 279\n\nThis change:\n* Adds a simple test for the `Text_Diff::_check()` method, which is how the bug was discovered as the test could never pass with the code as-is.\n\n* Adds a defensive guard to protect against the fatal. It checks if `$prevtype` is not `null` as a pre-condition to for checking the instance. This bugfix also resolves the failing test.\n\nFollow-up to [49194], [7747].\n\nProps jrf, hellofromTonya.\nSee #62083.\n\ngit-svn-id: https://develop.svn.wordpress.org/trunk@59070 602fd350-edb4-49c9-b593-d223f7449a82","shortMessageHtmlLink":"External Libraries: Skip instanceof check when null in Text_Diff::_ch…"}},{"before":"de346c606d9756bcaec8d0d69fe7aac3a86731fe","after":"1e608149f92886723d7d162df3014c7ba970030e","ref":"refs/heads/trunk","pushedAt":"2024-09-19T18:55:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pento","name":"Gary Pendergast","path":"/pento","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/352291?s=80&v=4"},"commit":{"message":"Code Modernization: handle mysqli_ping() deprecation in wpdb::check_connection().\n\nThe `mysqli_ping()` function is deprecated as of PHP 8.4, though, in reality, the function wasn't working according to spec anymore since PHP 8.2 when the `libmysql` driver was dropped in favour of `libmysqlnd`, which was already the default (and recommended) driver since PHP 5.4.\n\nThe `mysqli_ping()` method was also not really correctly named as its functionality was to reconnect to the database, not just ping.\n\nThe alternative is to \"manually\" ping the database by sending a `DO 1` query (the cheapest possible SQL query).\n\nAdding a PHP version based toggle was considered, but as mentioned above, the default driver has been `libmysqlnd` since PHP 5.4 and in that case, the function never worked anyway, so in reality `mysqli_ping()` was only really functional for the odd custom PHP compilation where `mysqli` was build against `libmysql` AND `reconnect` was not disabled.\n\nWith this in mind, this change replaces the call to `mysqli_ping()` with the `DO 1` query completely. If that query succeeds, it concludes the database connection is still alive. This solution should be the most stable as it will work for both PHP 7.2 <= 8.1, independently of which driver `mysqli` was compiled with, as well as for PHP 8.2+.\n\nNote: It could also be considered to remove the function call to `mysqli_ping()` completely and rely on standard error handling in case the connection would have dropped, as after all, the fact that the connection existed at the moment the \"ping\" happened, is no guarantee that the connection will still exist when the next query is send.... this approach was not chosen so as WP has custom error handling and does not use the PHP native mysqli exceptions for this, which would make implementing this more awkward.\n\nIncludes a test to verify that the connection check works when there is a valid connection (this was previously not covered by tests).\n\nRefs:\n* https://wiki.php.net/rfc/deprecations_php_8_4#mysqli_ping_and_mysqliping\n* https://github.com/php/php-src/pull/11912#issuecomment-1671762583\n* https://stackoverflow.com/questions/2546868/cheapest-way-to-determine-if-a-mysql-connection-is-still-alive/2546922#2546922\n* php/php-src#11945\n* https://wiki.php.net/rfc/mysqli_support_for_libmysql\n* https://www.php.net/mysqli_ping\n\nFollow-up to [56475], [27250], [27075].\n\nProps jrf, hellofromTonya.\nSee #62061.\n\ngit-svn-id: https://develop.svn.wordpress.org/trunk@59069 602fd350-edb4-49c9-b593-d223f7449a82","shortMessageHtmlLink":"Code Modernization: handle mysqli_ping() deprecation in wpdb::check_c…"}},{"before":"ceedcb5ae956b92288cd370a6e67789c196c95d1","after":"de346c606d9756bcaec8d0d69fe7aac3a86731fe","ref":"refs/heads/trunk","pushedAt":"2024-09-19T18:13:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pento","name":"Gary Pendergast","path":"/pento","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/352291?s=80&v=4"},"commit":{"message":"Tests: Remove use of E_STRICT.\n\nThe `E_STRICT` constant is deprecated as of PHP 8.4 and will be removed in PHP 9.0.\n\nThe error level hasn't been in use since PHP 8.0 anyway, so removing the exclusion from the `error_reporting()` setting in the `install.php` script used in the tests should make no difference in practice.\n\nRef:\n* https://wiki.php.net/rfc/deprecations_php_8_4#remove_e_strict_error_level_and_deprecate_e_strict_constant\n\nFollow-up to [25002].\n\nProps jrf.\nSee #62061.\n\ngit-svn-id: https://develop.svn.wordpress.org/trunk@59068 602fd350-edb4-49c9-b593-d223f7449a82","shortMessageHtmlLink":"Tests: Remove use of E_STRICT."}},{"before":"e060ee3eb715d18e4a2cb8ce7eb29d1fd0a29842","after":"ceedcb5ae956b92288cd370a6e67789c196c95d1","ref":"refs/heads/trunk","pushedAt":"2024-09-19T12:39:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pento","name":"Gary Pendergast","path":"/pento","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/352291?s=80&v=4"},"commit":{"message":"Coding Standards: Update PHPCS to version 3.10.3.\n\nPHPCS has seen several new releases since the last update, which means more bugs have been fixed, syntax support for PHP 8.3 was added, more sniff documentation is available, performance improvements, a new Help screen, etc.\n\nReferences:\n* [https://github.com/PHPCSStandards/PHP_CodeSniffer/releases/tag/3.10.3 PHP_CodeSniffer 3.10.3 release notes]\n* [https://github.com/PHPCSStandards/PHP_CodeSniffer/releases/tag/3.10.2 PHP_CodeSniffer 3.10.2 release notes]\n* [https://github.com/PHPCSStandards/PHP_CodeSniffer/releases/tag/3.10.1 PHP_CodeSniffer 3.10.1 release notes]\n* [https://github.com/PHPCSStandards/PHP_CodeSniffer/releases/tag/3.10.0 PHP_CodeSniffer 3.10.0 release notes]\n* [https://github.com/PHPCSStandards/PHP_CodeSniffer/releases/tag/3.9.2 PHP_CodeSniffer 3.9.2 release notes]\n* [https://github.com/PHPCSStandards/PHP_CodeSniffer/releases/tag/3.9.1 PHP_CodeSniffer 3.9.1 release notes]\n\nFollow-up to [56695], [56799], [57378], [57986].\n\nProps jrf.\nFixes #62076.\n\ngit-svn-id: https://develop.svn.wordpress.org/trunk@59067 602fd350-edb4-49c9-b593-d223f7449a82","shortMessageHtmlLink":"Coding Standards: Update PHPCS to version 3.10.3."}},{"before":"b36055bef3c7e0359a3c4cf1760d17b259c3234d","after":"e060ee3eb715d18e4a2cb8ce7eb29d1fd0a29842","ref":"refs/heads/trunk","pushedAt":"2024-09-19T12:11:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pento","name":"Gary Pendergast","path":"/pento","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/352291?s=80&v=4"},"commit":{"message":"Coding Standards: Remove unused return value for `WP_Object_Cache::__set()`.\n\nThis resolves a WPCS warning:\n{{{\nAssignments must be the first block of code on a line\n}}}\n\nNote: This is enforced by PHPCS 3.10.3.\n\nFollow-up to [28521], [29146].\n\nProps jrf.\nSee #62076, #61607.\n\ngit-svn-id: https://develop.svn.wordpress.org/trunk@59066 602fd350-edb4-49c9-b593-d223f7449a82","shortMessageHtmlLink":"Coding Standards: Remove unused return value for `WP_Object_Cache::__…"}},{"before":"bf09fe506620678fb82c3b872309edda0ed8ce61","after":"b36055bef3c7e0359a3c4cf1760d17b259c3234d","ref":"refs/heads/trunk","pushedAt":"2024-09-19T10:33:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pento","name":"Gary Pendergast","path":"/pento","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/352291?s=80&v=4"},"commit":{"message":"Bundled Themes: Make text strings translatable.\n\nThis changeset updates Twenty Twenty-Three and Twenty Twenty-Four and replaces text strings in HTML files with patterns to make the strings translatable.\n\nFollow-up to [58459].\n\nProps sabernhardt, karmatosed, iflairwebtechnologies, poena.\nFixes #61951.\n\ngit-svn-id: https://develop.svn.wordpress.org/trunk@59065 602fd350-edb4-49c9-b593-d223f7449a82","shortMessageHtmlLink":"Bundled Themes: Make text strings translatable."}},{"before":"3b248638618bcd40a315bee6027ea8b7dfc578e0","after":"bf09fe506620678fb82c3b872309edda0ed8ce61","ref":"refs/heads/trunk","pushedAt":"2024-09-18T22:36:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pento","name":"Gary Pendergast","path":"/pento","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/352291?s=80&v=4"},"commit":{"message":"Date/Time, PHP Compat: Prevent type errors using GMT offset option.\n\nPrevents a potential type errors when making use of the `gmt_offset` option by casting the value to a float prior to performing calculations with the value.\n\nThis mainly accounts for incorrect storage of values, such as an empty string or city name.\n\nFollow up to [58923].\n\nProps chaion07, hellofromtonya, kirasong, mhshohel, mukesh27, nicolefurlan, nihar007, nurielmeni, oglekler, peterwilsoncc, prionkor, rajinsharwar, rarst, rleeson, sabernhardt, SergeyBiryukov, swissspidy, toastercookie, verygoode.\nFixes #56358, #58986, #60629.\n\n\ngit-svn-id: https://develop.svn.wordpress.org/trunk@59064 602fd350-edb4-49c9-b593-d223f7449a82","shortMessageHtmlLink":"Date/Time, PHP Compat: Prevent type errors using GMT offset option."}},{"before":"ce571018a9d72fb513b803599cba21037fec68ed","after":"3b248638618bcd40a315bee6027ea8b7dfc578e0","ref":"refs/heads/trunk","pushedAt":"2024-09-18T21:39:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pento","name":"Gary Pendergast","path":"/pento","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/352291?s=80&v=4"},"commit":{"message":"Code Modernization: Remove xml_set_object() in MagpieRSS::__construct().\n\nThe XML Parser extension still supports a quite dated mechanism for method based callbacks, where the object is first set via `xml_set_object()` and the callbacks are then set by passing only the name of the method to the relevant parameters on any of the `xml_set_*_handler()` functions.\n\n{{{\nxml_set_object( $parser, $my_obj );\nxml_set_character_data_handler( $parser, 'method_name_on_my_obj' );\n}}}\n\nPassing proper callables to the `xml_set_*_handler()` functions has been supported for the longest time and is cross-version compatible. So the above code is 100% equivalent to:\n\n{{{\nxml_set_character_data_handler( $parser, [$my_obj, 'method_name_on_my_obj'] );\n}}}\n\nThe mechanism of setting the callbacks with `xml_set_object()` has now been deprecated as of PHP 8.4, in favour of passing proper callables to the `xml_set_*_handler()` functions. This is also means that calling the `xml_set_object()` function is deprecated as well.\n\nThis commit fixes this deprecation for the `MagpieRSS::__construct()` method.\n\nThe change has not been not covered by tests. This class has been deprecated since WP 3.0.0 and is not covered by tests at all. Adding those now seems superfluous, all the more as the principle of the fix is no different than for the other files, so we can be sure it works anyway.\n\nNote: Though this is \"officially\" an external library, this package is no longer externally maintained. The code style of the fix in the source file is in line with the existing code style for the file.\n\nRefs:\n* https://wiki.php.net/rfc/deprecations_php_8_4#xml_set_object_and_xml_set_handler_with_string_method_names\n* https://www.php.net/manual/en/function.xml-set-object.php\n* https://www.php.net/manual/en/ref.xml.php\n\nFollow-up to [4399].\n\nProps jrf.\nSee #62061.\n\ngit-svn-id: https://develop.svn.wordpress.org/trunk@59063 602fd350-edb4-49c9-b593-d223f7449a82","shortMessageHtmlLink":"Code Modernization: Remove xml_set_object() in MagpieRSS::__construct()."}},{"before":"f9f19c7e77bc5898b03a69a48871cd377320c378","after":"ce571018a9d72fb513b803599cba21037fec68ed","ref":"refs/heads/trunk","pushedAt":"2024-09-18T21:19:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pento","name":"Gary Pendergast","path":"/pento","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/352291?s=80&v=4"},"commit":{"message":"Code Modernization: Remove xml_set_object() in AtomParser::parse().\n\nThe XML Parser extension still supports a quite dated mechanism for method based callbacks, where the object is first set via `xml_set_object()` and the callbacks are then set by passing only the name of the method to the relevant parameters on any of the `xml_set_*_handler()` functions.\n\n{{{\nxml_set_object( $parser, $my_obj );\nxml_set_character_data_handler( $parser, 'method_name_on_my_obj' );\n}}}\n\nPassing proper callables to the `xml_set_*_handler()` functions has been supported for the longest time and is cross-version compatible. So the above code is 100% equivalent to:\n\n{{{\nxml_set_character_data_handler( $parser, [$my_obj, 'method_name_on_my_obj'] );\n}}}\n\nThe mechanism of setting the callbacks with `xml_set_object()` has now been deprecated as of PHP 8.4, in favour of passing proper callables to the `xml_set_*_handler()` functions. This is also means that calling the `xml_set_object()` function is deprecated as well.\n\nThis commit fixes this deprecation for the `AtomParser::parse()` method.\n\nThis change is safeguarded via the new `AtomParser_Parse_Test` class.\n\nNotes:\n* Though this is \"officially\" an external library, this package is no longer externally maintained. The code style of the fix in the source file is in line with the existing code style for the file.\n* It appears that this class is not actually used by WP Core itself, so it could be considered to deprecate the class. However, as the class is not currently deprecated, safeguarding the change with a test seemed prudent.\n* The fixture used for the test reuses a fixture from the original package: https://code.google.com/archive/p/phpatomlib/source/default/source\n* The new test class follows the recommended test format (naming convention of the class, `@covers` tag at class level, only testing one method) as per Trac tickets 62004 / 53010.\n\nRefs:\n* https://wiki.php.net/rfc/deprecations_php_8_4#xml_set_object_and_xml_set_handler_with_string_method_names\n* https://www.php.net/manual/en/function.xml-set-object.php\n* https://www.php.net/manual/en/ref.xml.php\n\nFollow-up to [5951].\n\nProps jrf.\nSee #62061.\n\ngit-svn-id: https://develop.svn.wordpress.org/trunk@59062 602fd350-edb4-49c9-b593-d223f7449a82","shortMessageHtmlLink":"Code Modernization: Remove xml_set_object() in AtomParser::parse()."}},{"before":"5168e1933af6e2e753b5fce4ed0f6fc29bd4fec1","after":"f9f19c7e77bc5898b03a69a48871cd377320c378","ref":"refs/heads/trunk","pushedAt":"2024-09-18T21:05:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pento","name":"Gary Pendergast","path":"/pento","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/352291?s=80&v=4"},"commit":{"message":"Tests: Use file paths independent of OS-specifics assertion or helper.\n\nUse `WP_UnitTestCase_Base::assertSamePathIgnoringDirectorySeparators()` and `WP_UnitTestCase_Base::normalizeDirectorySeparatorsInPath()` in existing tests.\n\nFollow-up to [59057], [57753], [57215], [56635], [48937], [25002].\n\nProps jrf.\nSee #61530.\n\ngit-svn-id: https://develop.svn.wordpress.org/trunk@59061 602fd350-edb4-49c9-b593-d223f7449a82","shortMessageHtmlLink":"Tests: Use file paths independent of OS-specifics assertion or helper."}},{"before":"a543c31a1d0f6a86c664e5225f3befe03fb91807","after":"5168e1933af6e2e753b5fce4ed0f6fc29bd4fec1","ref":"refs/heads/trunk","pushedAt":"2024-09-18T19:11:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pento","name":"Gary Pendergast","path":"/pento","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/352291?s=80&v=4"},"commit":{"message":"WP_Debug_Data: Extract `wp-media` data into separate method.\n\nThis is the sixth part in a larger modularization of the data in `WP_Debug_Data`. Previously this was a single massive method drawing in debug data from various groups of related data, where the groups were independent from each other.\n\nThis patch separates the sixth of twelve groups, the `wp-media` info, into a separate method focused on that data.\n\nThis work precedes changes to make the `WP_Debug_Data` class more extensible for better use by plugin and theme code.\n\nDeveloped in https://github.com/wordpress/wordpress-develop/pull/7356\nDiscussed in https://core.trac.wordpress.org/ticket/61648\n\nProps apermo, dmsnell.\nSee #61648.\n\n\ngit-svn-id: https://develop.svn.wordpress.org/trunk@59060 602fd350-edb4-49c9-b593-d223f7449a82","shortMessageHtmlLink":"WP_Debug_Data: Extract <code>wp-media</code> data into separate method."}},{"before":"55aa76aa25e9f0f31a54f7bbe3e840b24427d314","after":"a543c31a1d0f6a86c664e5225f3befe03fb91807","ref":"refs/heads/trunk","pushedAt":"2024-09-18T19:07:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pento","name":"Gary Pendergast","path":"/pento","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/352291?s=80&v=4"},"commit":{"message":"Docs: The `$feedname` parameter in `add_feed()` should not start with an underscore.\n\nProps snehapatil02, hellofromtonya, narenin.\nFixes #59945.\n\n\ngit-svn-id: https://develop.svn.wordpress.org/trunk@59059 602fd350-edb4-49c9-b593-d223f7449a82","shortMessageHtmlLink":"Docs: The <code>$feedname</code> parameter in <code>add_feed()</code> should not start with…"}},{"before":"e6a8fdd754887ec5b2738013163552a0b8c0be76","after":"55aa76aa25e9f0f31a54f7bbe3e840b24427d314","ref":"refs/heads/trunk","pushedAt":"2024-09-18T18:45:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pento","name":"Gary Pendergast","path":"/pento","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/352291?s=80&v=4"},"commit":{"message":"Code Modernization: Explicitly declare all properties in AtomParser.\n\nDynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0.\n\nThere are a number of ways to mitigate this:\n* If it's an accidental typo for a declared property: fix the typo.\n* For known properties: declare them on the class.\n* For unknown properties: add the magic `__get()`, `__set()` et al methods to the class or let the class extend `stdClass` which has highly optimized versions of these magic methods build in.\n* For unknown _use of_ dynamic properties, the `#[AllowDynamicProperties]` attribute can be added to the class. The attribute will automatically be inherited by child classes.\n\nIn this case, the property added are explicitly referenced in this class, so fall in the \"known property\" category.\n\nRefs:\n* https://wiki.php.net/rfc/deprecate_dynamic_properties\n\nProps jrf.\nSee #56034.\n\ngit-svn-id: https://develop.svn.wordpress.org/trunk@59058 602fd350-edb4-49c9-b593-d223f7449a82","shortMessageHtmlLink":"Code Modernization: Explicitly declare all properties in AtomParser."}},{"before":"baff405508b09c2fa165f60ffb2eec87515d6f1d","after":"e6a8fdd754887ec5b2738013163552a0b8c0be76","ref":"refs/heads/trunk","pushedAt":"2024-09-18T18:21:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pento","name":"Gary Pendergast","path":"/pento","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/352291?s=80&v=4"},"commit":{"message":"Tests: Introduce assertion for comparing file paths independent of OS-specifics.\n\nIntroduces `WP_UnitTestCase_Base::assertSamePathIgnoringDirectorySeparators()` and an associated helper method `WP_UnitTestCase_Base::normalizeDirectorySeparatorsInPath()` to allow for comparing two file path strings independently of OS-specific differences.\n\nThe normalization is done in a separate method to also allow this method to be used for path normalization within test methods themselves, like for normalizing a group of paths in an array.\n\nThe pretty specific method name for the helper (`normalizeDirectorySeparatorsInPath()`) is an attempt to prevent naming conflicts with methods which may exist in plugin test suites build on top of the WP Core test suite.\n\nProps jrf, hellofromTonya.\nSee #61530.\n\ngit-svn-id: https://develop.svn.wordpress.org/trunk@59057 602fd350-edb4-49c9-b593-d223f7449a82","shortMessageHtmlLink":"Tests: Introduce assertion for comparing file paths independent of OS…"}},{"before":"224e2c17b26caff406a4f5d44fa53901b1b4de7f","after":"baff405508b09c2fa165f60ffb2eec87515d6f1d","ref":"refs/heads/trunk","pushedAt":"2024-09-18T18:03:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pento","name":"Gary Pendergast","path":"/pento","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/352291?s=80&v=4"},"commit":{"message":"Code Modernization: Remove xml_set_object() in IXR_Message::parse().\n\nThe XML Parser extension still supports a quite dated mechanism for method based callbacks, where the object is first set via `xml_set_object()` and the callbacks are then set by passing only the name of the method to the relevant parameters on any of the `xml_set_*_handler()` functions.\n\n{{{\nxml_set_object( $parser, $my_obj );\nxml_set_character_data_handler( $parser, 'method_name_on_my_obj' );\n}}}\n\nPassing proper callables to the `xml_set_*_handler()` functions has been supported for the longest time and is cross-version compatible. So the above code is 100% equivalent to:\n\n{{{\nxml_set_character_data_handler( $parser, [$my_obj, 'method_name_on_my_obj'] );\n}}}\n\nThe mechanism of setting the callbacks with `xml_set_object()` has now been deprecated as of PHP 8.4, in favour of passing proper callables to the `xml_set_*_handler()` functions. This is also means that calling the `xml_set_object()` function is deprecated as well.\n\nThis commit fixes this deprecation for the `IXR_Message::parse()` method.\n\nThis change is safeguarded via the new`Tests_XMLRPC_Message::test_parse_sets_handlers()` test method.\n\nNote: Though this is \"officially\" an external library, this package is no longer externally maintained. The code style of the fix in the source file is in line with the existing code style for the file.\n\nRefs:\n* https://wiki.php.net/rfc/deprecations_php_8_4#xml_set_object_and_xml_set_handler_with_string_method_names\n* https://www.php.net/manual/en/function.xml-set-object.php\n* https://www.php.net/manual/en/ref.xml.php\n\nFollow-up to [15612], [1346].\n\nProps jrf, hellofromTonya.\nSee #62061.\n\ngit-svn-id: https://develop.svn.wordpress.org/trunk@59056 602fd350-edb4-49c9-b593-d223f7449a82","shortMessageHtmlLink":"Code Modernization: Remove xml_set_object() in IXR_Message::parse()."}},{"before":"1324176d519e02d969fb41c00de6b4d2751d0ad8","after":"224e2c17b26caff406a4f5d44fa53901b1b4de7f","ref":"refs/heads/trunk","pushedAt":"2024-09-18T17:25:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pento","name":"Gary Pendergast","path":"/pento","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/352291?s=80&v=4"},"commit":{"message":"Tests: Remove use of xml_set_object() in TestXMLParser.\n\nThe XML Parser extension still supports a quite dated mechanism for method based callbacks, where the object is first set via `xml_set_object()` and the callbacks are then set by passing only the name of the method to the relevant parameters on any of the `xml_set_*_handler()` functions.\n\n{{{\nxml_set_object( $parser, $my_obj );\nxml_set_character_data_handler( $parser, 'method_name_on_my_obj' );\n}}}\n\nPassing proper callables to the `xml_set_*_handler()` functions has been supported for the longest time and is cross-version compatible. So the above code is 100% equivalent to:\n\n{{{\nxml_set_character_data_handler( $parser, [$my_obj, 'method_name_on_my_obj'] );\n}}}\n\nThe mechanism of setting the callbacks with `xml_set_object()` has now been deprecated as of PHP 8.4, in favour of passing proper callables to the `xml_set_*_handler()` functions. This is also means that calling the `xml_set_object()` function is deprecated as well.\n\nThis commit fixes this deprecation for the `TestXMLParser` helper utility. In this case, the callbacks were already using the recommended format and the call to `xml_set_object()` was completely redundant.\n\nAs this is a test utility and was already causing pre-existing tests using the utility to fail, there is no need for dedicated tests to cover this change.\n\nRefs:\n* https://wiki.php.net/rfc/deprecations_php_8_4#xml_set_object_and_xml_set_handler_with_string_method_names\n* https://www.php.net/manual/en/function.xml-set-object.php\n* https://www.php.net/manual/en/ref.xml.php\n\nFollow-up to [25002].\n\nProps jrf.\nSee #62061.\n\ngit-svn-id: https://develop.svn.wordpress.org/trunk@59055 602fd350-edb4-49c9-b593-d223f7449a82","shortMessageHtmlLink":"Tests: Remove use of xml_set_object() in TestXMLParser."}},{"before":"82171f503600c8fa89e298a7b3ae76710d4be44d","after":"1324176d519e02d969fb41c00de6b4d2751d0ad8","ref":"refs/heads/trunk","pushedAt":"2024-09-18T16:17:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pento","name":"Gary Pendergast","path":"/pento","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/352291?s=80&v=4"},"commit":{"message":"Tests: Fix Tests_Theme tests to run (and pass) cross-OS.\n\nUses `DIRECTORY_SEPARATOR` in closures for cross-OS differences.\n\nFollow-up to [56635].\n\nProps jrf.\nSee #61530.\n\ngit-svn-id: https://develop.svn.wordpress.org/trunk@59054 602fd350-edb4-49c9-b593-d223f7449a82","shortMessageHtmlLink":"Tests: Fix Tests_Theme tests to run (and pass) cross-OS."}},{"before":"8fc4a000fceb64668e7d3962d01f32d8cdc2c82e","after":"82171f503600c8fa89e298a7b3ae76710d4be44d","ref":"refs/heads/trunk","pushedAt":"2024-09-18T15:03:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pento","name":"Gary Pendergast","path":"/pento","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/352291?s=80&v=4"},"commit":{"message":"Code Modernization: Fix implicitly nullable parameter in WP_HTML_Processor.\n\nPHP 8.4 deprecates implicitly nullable parameters, i.e. typed parameters with a `null` default value, which are not explicitly declared as nullable.\n\nThis commit the one instance of this in the `WP_HTML_Processor` class.\n\nFixed by adding the nullability operator to the type, which is supported since PHP 7.1, so we can use it now the minimum supported PHP version is PHP 7.2.\n\nAs this deprecation is thrown at compile time, it can be seen at the top of the test output when running on PHP 8.4 (which will be gone once this change has been committed). It is not possible to write a test to cover this.\n\nRef: https://wiki.php.net/rfc/deprecate-implicitly-nullable-types\n\nFollow-up to [58867], [58769], [58304], [58192].\n\nProps jrf.\nSee #62061.\n\ngit-svn-id: https://develop.svn.wordpress.org/trunk@59053 602fd350-edb4-49c9-b593-d223f7449a82","shortMessageHtmlLink":"Code Modernization: Fix implicitly nullable parameter in WP_HTML_Proc…"}},{"before":"91f8e77b3e19dde884cd6a32a8799e8c71db9e92","after":"8fc4a000fceb64668e7d3962d01f32d8cdc2c82e","ref":"refs/heads/trunk","pushedAt":"2024-09-18T14:54:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pento","name":"Gary Pendergast","path":"/pento","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/352291?s=80&v=4"},"commit":{"message":"Tests: Fix implicitly nullable parameters in Tests_HtmlApi_WpHtmlProcessorComments.\n\nPHP 8.4 deprecates implicitly nullable parameters, i.e. typed parameters with a `null` default value, which are not explicitly declared as nullable.\n\nThe `Tests_HtmlApi_WpHtmlProcessorComments` test class contains one problematic parameter in the `test_comment_processing()` method declaration.\n\nWhile this could be fixed by adding the nullability operator, the type declarations in the test method is removed instead, including other type declarations for this method and the second test method, which were not affected by the deprecation.\n\nThe reason for this is quite straight-forward: using type declarations in tests is bad practice and inhibits defense-in-depth type testing.\n\nUsing type declarations in tests prevents being able to test the \"code under test\" with unexpected input types as the values with unexpected (scalar) types will be juggled to the expected type between the data provider and the test method and the _real_ data value would therefore never reach the method under test.\n\nThe knock-on effects of this are:\n* That the input handling of the \"code under test\" can not be safeguarded, whether this input handling is done via in-function type checking or via a type declaration in the \"code under test\".\n* That if such \"unexpected data type\" tests are added to the data provider, they will silently pass (due to the type being juggled before reaching the \"code under test\"), giving a false sense of security, while in actual fact, these data sets would not be testing anything at all and if, for instance, the type declaration in the \"code under test\" would be removed, these tests would still pass, while by rights they should start failing.\n\nAlso note that this problem would only be exacerbated if the file would be put under `strict_types`.\n\nRef: https://wiki.php.net/rfc/deprecate-implicitly-nullable-types\n\nFollow-up to [58734].\n\nProps jrf.\nSee #62061.\n\ngit-svn-id: https://develop.svn.wordpress.org/trunk@59052 602fd350-edb4-49c9-b593-d223f7449a82","shortMessageHtmlLink":"Tests: Fix implicitly nullable parameters in Tests_HtmlApi_WpHtmlProc…"}},{"before":"d8e05446b7d109f8b3c48cbeebf6241d3f6e3946","after":"91f8e77b3e19dde884cd6a32a8799e8c71db9e92","ref":"refs/heads/trunk","pushedAt":"2024-09-18T14:23:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pento","name":"Gary Pendergast","path":"/pento","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/352291?s=80&v=4"},"commit":{"message":"Script Loader: Restore `user-profile.js` dependencies after an accidental revert.\n\nFollow-up to [59033], [59046], [59047].\n\nProps TobiasBg.\nSee #61754.\n\ngit-svn-id: https://develop.svn.wordpress.org/trunk@59051 602fd350-edb4-49c9-b593-d223f7449a82","shortMessageHtmlLink":"Script Loader: Restore <code>user-profile.js</code> dependencies after an accide…"}},{"before":"a6166f143444b48eb7250de76a5b8eeee3a7ee34","after":"d8e05446b7d109f8b3c48cbeebf6241d3f6e3946","ref":"refs/heads/trunk","pushedAt":"2024-09-18T06:03:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pento","name":"Gary Pendergast","path":"/pento","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/352291?s=80&v=4"},"commit":{"message":"Docs: Add missing @since and @param annotations for the `edit_post_{$field}` hook doc.\n\nProps mukesh27\nSee #50654\n\n\ngit-svn-id: https://develop.svn.wordpress.org/trunk@59050 602fd350-edb4-49c9-b593-d223f7449a82","shortMessageHtmlLink":"Docs: Add missing <a class=\"user-mention notranslate\" data-hovercard-type=\"user\" data-hovercard-url=\"/users/SInCE/hovercard\" data-octo-click=\"hovercard-link-click\" data-octo-dimensions=\"link_type:self\" href=\"https://github.com/SInCE\">@SInCE</a> and <a class=\"user-mention notranslate\" data-hovercard-type=\"user\" data-hovercard-url=\"/users/param/hovercard\" data-octo-click=\"hovercard-link-click\" data-octo-dimensions=\"link_type:self\" href=\"https://github.com/param\">@param</a> annotations for the `edit_post_{$…"}},{"before":"52d46a9cb3d808340f2d7b35a0120354bf8ecaf2","after":"a6166f143444b48eb7250de76a5b8eeee3a7ee34","ref":"refs/heads/trunk","pushedAt":"2024-09-18T05:43:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pento","name":"Gary Pendergast","path":"/pento","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/352291?s=80&v=4"},"commit":{"message":"Build/Test Tools: Submit host test results for each PHP version.\n\nThe WordPress Hosting Test Results now supports multiple reports for the same commit from the same test bot. This updates the PHPUnit test workflow to submit results for each version of PHP running the tests.\n\nProps swissspidy, jorbin, crixu, kirasong, desrosj.\nSee #61564.\n\ngit-svn-id: https://develop.svn.wordpress.org/trunk@59049 602fd350-edb4-49c9-b593-d223f7449a82","shortMessageHtmlLink":"Build/Test Tools: Submit host test results for each PHP version."}},{"before":"6693c25c8a786925d16c466694d35c0ea3764e67","after":"52d46a9cb3d808340f2d7b35a0120354bf8ecaf2","ref":"refs/heads/trunk","pushedAt":"2024-09-18T05:18:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pento","name":"Gary Pendergast","path":"/pento","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/352291?s=80&v=4"},"commit":{"message":"Global Styles: allow read access to users with `edit_posts` capabilities \n\nThis patch any role that can edit a post, including custom post types, or edit theme options to read global styles from the API. This enables read-only access to global styles in the post editor. Test coverage in included.\n\nProps ramonopoly, peterwilsoncc, mukesh27, aaronrobertshaw, mamaduka, spacedmonkey, talldanwp, timothyblynjacobs.\nFixes #62042.\n\n\n\n\ngit-svn-id: https://develop.svn.wordpress.org/trunk@59048 602fd350-edb4-49c9-b593-d223f7449a82","shortMessageHtmlLink":"Global Styles: allow read access to users with <code>edit_posts</code> capabilities"}},{"before":"5d0753bb6e7c29adc8e6171ee21338cb5ade297b","after":"6693c25c8a786925d16c466694d35c0ea3764e67","ref":"refs/heads/trunk","pushedAt":"2024-09-18T00:47:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pento","name":"Gary Pendergast","path":"/pento","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/352291?s=80&v=4"},"commit":{"message":"Script Loader: Revert removing unused array_merge.\n\nCode is poetry, until it isn’t.\n\nUnprops davidbaumwald.\nSee #61754.\n\ngit-svn-id: https://develop.svn.wordpress.org/trunk@59047 602fd350-edb4-49c9-b593-d223f7449a82","shortMessageHtmlLink":"Script Loader: Revert removing unused array_merge."}},{"before":"b0809808e21827e4f6d0325695f37b67211067d5","after":"5d0753bb6e7c29adc8e6171ee21338cb5ade297b","ref":"refs/heads/trunk","pushedAt":"2024-09-18T00:13:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pento","name":"Gary Pendergast","path":"/pento","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/352291?s=80&v=4"},"commit":{"message":"Application Passwords: Add copy button when adding new password.\n\nProps circlecube, dhruvang21, ironprogrammer, desrosj.\nFixes #62019.\n\n\ngit-svn-id: https://develop.svn.wordpress.org/trunk@59046 602fd350-edb4-49c9-b593-d223f7449a82","shortMessageHtmlLink":"Application Passwords: Add copy button when adding new password."}},{"before":"e9bb88d8c2da2c5ea1831ecbd7909ae19ba29708","after":"b0809808e21827e4f6d0325695f37b67211067d5","ref":"refs/heads/trunk","pushedAt":"2024-09-18T00:01:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pento","name":"Gary Pendergast","path":"/pento","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/352291?s=80&v=4"},"commit":{"message":"Docs: Add possible filter names to the hook docs for the following filters in `sanitize_post_field()`:\n\n- `edit_{$field}`\n- `{$field_no_prefix}_edit_pre`\n- `edit_post_{$field}`\n- `pre_{$field}`\n- `{$field_no_prefix}_save_pre`\n- `pre_post_{$field}`\n- `{$field}_pre`\n- `{$field}`\n- `post_{$field}`\n\nProps johnbillion, DrewAPicture.\nFixes #50654\n\n\ngit-svn-id: https://develop.svn.wordpress.org/trunk@59045 602fd350-edb4-49c9-b593-d223f7449a82","shortMessageHtmlLink":"Docs: Add possible filter names to the hook docs for the following fi…"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEu3__-AA","startCursor":null,"endCursor":null}},"title":"Activity · WordPress/wordpress-develop"}