Commit de3d356
committed
Fix collaboration E2E tests failing due to inline script timing
wp_collaboration_inject_setting was hooked to admin_init, but
wp-core-data is not registered at that point, causing
wp_add_inline_script to silently fail. Move the hook to
enqueue_block_editor_assets where the handle is guaranteed to exist.
Also replace the fragile form-scraping setCollaboration helper with
requestUtils.updateSiteSettings and tolerate pre-existing test users
so interrupted runs do not break subsequent test executions.1 parent 90e9566 commit de3d356
3 files changed
Lines changed: 13 additions & 30 deletions
File tree
- src/wp-includes
- tests/e2e/specs/collaboration/fixtures
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
796 | 796 | | |
797 | 797 | | |
798 | 798 | | |
799 | | - | |
| 799 | + | |
800 | 800 | | |
801 | 801 | | |
802 | 802 | | |
| |||
Lines changed: 2 additions & 27 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | 88 | | |
93 | 89 | | |
94 | 90 | | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | | - | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | | - | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | | - | |
| 91 | + | |
| 92 | + | |
118 | 93 | | |
119 | 94 | | |
120 | 95 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
36 | | - | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
37 | 45 | | |
38 | 46 | | |
39 | 47 | | |
| |||
0 commit comments