Merge pull request #194 from Workiva/fixed_enclosing_range_calculation

btr-rmconsole-1[bot] · web-flow · commit 130978e53ac7 · 2025-10-17T03:07:54.000Z
FEDX-4075: Fixed enclosing_range calculation
diff --git a/lib/src/scip_visitor.dart b/lib/src/scip_visitor.dart
@@ -180,7 +180,7 @@ class ScipVisitor extends GeneralizingAstVisitor {
       symbol: symbol,
       symbolRoles: SymbolRole.Definition.value,
       diagnostics: meta.diagnostics,
-      enclosingRange: _lineInfo.getRange(node.offset, node.end),
+      enclosingRange: _lineInfo.getRange(node.offset, node.length),
     ));
   }
 }
diff --git a/lib/src/utils.dart b/lib/src/utils.dart
@@ -33,9 +33,9 @@ void display(String input, {DisplayLevel level = DisplayLevel.warn}) {
 }
 
 extension LineInfoExtension on LineInfo {
-  List<int> getRange(int offset, int nameLength) {
+  List<int> getRange(int offset, int length) {
     final start = getLocation(offset);
-    final end = getLocation(offset + nameLength);
+    final end = getLocation(offset + length);
 
     final res = [
       start.lineNumber - 1,

Original file line number	Diff line number	Diff line change
`@@ -180,7 +180,7 @@ class ScipVisitor extends GeneralizingAstVisitor {`
`180`	`180`	`symbol: symbol,`
`181`	`181`	`symbolRoles: SymbolRole.Definition.value,`
`182`	`182`	`diagnostics: meta.diagnostics,`
`183`		`- enclosingRange: _lineInfo.getRange(node.offset, node.end),`
	`183`	`+ enclosingRange: _lineInfo.getRange(node.offset, node.length),`
`184`	`184`	`));`
`185`	`185`	`}`
`186`	`186`	`}`