Skip to content

Accounting Organisation class ENUM values in 2.x branch are now incomplete #384

Description

@wallacio

SDK you're using

  • Version 2.23.x

Describe the bug
Valid organisation ENUMs have not been backported to 2.x branch, which I believe is still maintained and valid. An organisation which has the class 'COMPREHENSIVE' throws an exception in getOrganisation.

InvalidArgumentException: Invalid value for 'class', must be one of 'DEMO', 'TRIAL', 'STARTER', 'STANDARD', 'PREMIUM', 'PREMIUM_20', 'PREMIUM_50', 'PREMIUM_100', 'LEDGER', 'GST_CASHBOOK', 'NON_GST_CASHBOOK', 'ULTIMATE', 'LITE' in vendor/xeroapi/xero-php-oauth2/lib/Models/Accounting/Organisation.php:1508

Expected behavior
Valid ENUM values returned in Models\Accounting\Organisation::getClassAllowableValues() to be backported to 2.x branch (which I think is the last supported branch with firebase/php-jwt:5.x

Additional context
#351

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions