- 
                Notifications
    
You must be signed in to change notification settings  - Fork 58
 
Closed
Description
Which version of the SDK are you using?
1.10.0
A quick summary and/or background
Discovered this issue when debugging refresh token issues with @RettBehrens .
If scope is passed as a str (or another type) rather than a list in the token set to the helper method store_xero_oauth2_token, then refresh_oauth2_token will return None rather than the refreshed token set.
Steps to reproduce
- Pass 
scopesas a space delimited string within the token set passed to anstore_xero_oauth2_token - Call 
refresh_oauth2_token - Verify the return value of 
refresh_oauth2_tokenisNone 
What you expected would happen
- Pass 
scopesas a space delimited string within the token set passed to anstore_xero_oauth2_token - Call 
refresh_oauth2_token can_refresh_access_tokenraises an error describing why the token cannot be refreshed: in this case, the error should state that scope must be alistofstr
What actually happens
- Pass 
scopesas a space delimited string within the token set passed to anstore_xero_oauth2_token - Call 
refresh_oauth2_token - Since the return value of 
refresh_oauth2_tokenis not needed sincestore_xero_oauth2_tokenis called internally withinrefresh_oauth2_token, the issue is invisible and a silent failure occurs - The issue becomes known when the access token expires since it can never be refreshed due to failing type validation
 
Metadata
Metadata
Assignees
Labels
No labels