ef_vi_for_each_tx_error_failed_transmit is a tad noisy with clang

[lukester1975]

Hello

warning: comparison of integers of different signs: 'unsigned int' and '::ef_request_id' (aka 'int') [-Wsign-compare]
  848 |                 ef_vi_for_each_tx_error_failed_transmit(&m_vi, id)
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
... note: expanded from macro 'ef_vi_for_each_tx_error_failed_transmit'
 3080 |     if( EF_REQUEST_ID_MASK != \
      |         ~~~~~~~~~~~~~~~~~~ ^
 3081 |         ((dma_id) = (vi)->vi_txq.ids[(vi)->ep_state->txq.removed & \
      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 3082 |                                      (vi)->vi_txq.mask]) )
      |                                      ~~~~~~~~~~~~~~~~~~

Would you mind adding a cast? I can PR lukester1975@c43af27 if you like.

I also noticed a comment referring to EF_PD_LLCT_PD which should presumably be EF_PD_EXPRESS_PD (lukester1975@1391ee6, though maybe the other reference to "LLCT datapath" there also should be changed?).

Also: https://github.com/Xilinx-CNS/onload/blob/10f8ae3dfbd0798ed1869aa589c564a850eb4eca/src/include/etherfabric/vi.h#L48-L5

It looks like with the express datapath on x4 the default rxq capacity is 1024?

Thanks