Skip to content

Commit 1596ac6

Browse files
akxdvora-h
andauthored
Remove mentions of Tox (redis#2929)
It was removed in redis#2849. Co-authored-by: dvora-h <[email protected]>
1 parent 8c8a529 commit 1596ac6

7 files changed

+2
-35
lines changed

.dockerignore

-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
**/__pycache__
22
**/*.pyc
3-
.tox
43
.coverage
54
.coverage.*

.flake8

-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ exclude =
44
*.egg-info,
55
*.pyc,
66
.git,
7-
.tox,
87
.venv*,
98
build,
109
docs/*,

.github/PULL_REQUEST_TEMPLATE.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
_Please make sure to review and check all of these items:_
44

5-
- [ ] Does `$ tox` pass with this change (including linting)?
5+
- [ ] Do tests and lints pass with this change?
66
- [ ] Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
77
- [ ] Is the new or changed code fully tested?
88
- [ ] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

.github/wordlist.txt

-1
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,6 @@ thevalueofmykey
132132
timeseries
133133
toctree
134134
topk
135-
tox
136135
triaging
137136
txt
138137
un

.gitignore

-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ redis.egg-info
33
build/
44
dist/
55
dump.rdb
6-
/.tox
76
_build
87
vagrant/.vagrant
98
.python-version

CONTRIBUTING.md

+1-29
Original file line numberDiff line numberDiff line change
@@ -78,16 +78,9 @@ It is possible to run only Redis client tests (with cluster mode disabled) by
7878
using `invoke standalone-tests`; similarly, RedisCluster tests can be run by using
7979
`invoke cluster-tests`.
8080

81-
Each run of tox starts and stops the various dockers required. Sometimes
81+
Each run of tests starts and stops the various dockers required. Sometimes
8282
things get stuck, an `invoke clean` can help.
8383

84-
Continuous Integration uses these same wrappers to run all of these
85-
tests against multiple versions of python. Feel free to test your
86-
changes against all the python versions supported, as declared by the
87-
tox.ini file (eg: tox -e py39). If you have the various python versions
88-
on your desktop, you can run *tox* by itself, to test all supported
89-
versions.
90-
9184
### Docker Tips
9285

9386
Following are a few tips that can help you work with the Docker-based
@@ -97,10 +90,6 @@ To get a bash shell inside of a container:
9790

9891
`$ docker run -it <service> /bin/bash`
9992

100-
**Note**: The term \"service\" refers to the \"services\" defined in the
101-
`tox.ini` file at the top of the repo: \"master\", \"replicaof\",
102-
\"sentinel_1\", \"sentinel_2\", \"sentinel_3\".
103-
10493
Containers run a minimal Debian image that probably lacks tools you want
10594
to use. To install packages, first get a bash session (see previous tip)
10695
and then run:
@@ -111,23 +100,6 @@ You can see the logging output of a containers like this:
111100

112101
`$ docker logs -f <service>`
113102

114-
The command make test runs all tests in all tested Python
115-
environments. To run the tests in a single environment, like Python 3.9,
116-
use a command like this:
117-
118-
`$ docker-compose run test tox -e py39 -- --redis-url=redis://master:6379/9`
119-
120-
Here, the flag `-e py39` runs tests against the Python 3.9 tox
121-
environment. And note from the example that whenever you run tests like
122-
this, instead of using make test, you need to pass
123-
`-- --redis-url=redis://master:6379/9`. This points the tests at the
124-
\"master\" container.
125-
126-
Our test suite uses `pytest`. You can run a specific test suite against
127-
a specific Python version like this:
128-
129-
`$ docker-compose run test tox -e py37 -- --redis-url=redis://master:6379/9 tests/test_commands.py`
130-
131103
### Troubleshooting
132104

133105
If you get any errors when running `make dev` or `make test`, make sure

dev_requirements.txt

-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ packaging>=20.4
88
pytest==7.2.0
99
pytest-timeout==2.1.0
1010
pytest-asyncio>=0.20.2
11-
tox==3.27.1
1211
invoke==1.7.3
1312
pytest-cov>=4.0.0
1413
vulture>=2.3.0

0 commit comments

Comments
 (0)