Merge pull request #1025 from Yelp/u/kkasp/DAR-2558-fix-overstep

KaspariK · web-flow · commit 4fb97dfa52f5 · 2025-01-30T14:58:25.000-05:00
Fix loop boundary on getting partitions
diff --git a/tron/serialize/runstate/dynamodb_state_store.py b/tron/serialize/runstate/dynamodb_state_store.py
@@ -138,7 +138,7 @@ def _get_remaining_partitions(self, items: list, read_json: bool):
                 # we start from 1 since we already have the 0th partition and we get the rest of the partitions
                 # based on the max number of partitions, whether that number is the partitions for the pickled objects
                 # or the partitions for the json data
-                for i in range(1, max_partitions + 1)
+                for i in range(1, max_partitions)
             ]
             keys_for_remaining_items.extend(remaining_items)
         return self._get_items(keys_for_remaining_items)

Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,7 @@ def _get_remaining_partitions(self, items: list, read_json: bool):`
`138`	`138`	`# we start from 1 since we already have the 0th partition and we get the rest of the partitions`
`139`	`139`	`# based on the max number of partitions, whether that number is the partitions for the pickled objects`
`140`	`140`	`# or the partitions for the json data`
`141`		`- for i in range(1, max_partitions + 1)`
	`141`	`+ for i in range(1, max_partitions)`
`142`	`142`	`]`
`143`	`143`	`keys_for_remaining_items.extend(remaining_items)`
`144`	`144`	`return self._get_items(keys_for_remaining_items)`