Merge pull request #403 from Yoast/feature/phpstan-tweaks

PHPStan: minor tweaks

Author: jrfnl

Yoast/Sniffs/NamingConventions/NamespaceNameSniff.php

@@ -424,7 +424,7 @@ private function validate_src_directory( File $phpcsFile ) {
 		$this->validated_src_directory = [];
 
 		// Note: the check whether a basepath is available is done in the main `process()` routine.
-		$base_path = PathHelper::normalize_absolute_path( $phpcsFile->config->basepath );
+		$base_path = PathHelper::normalize_absolute_path( $phpcsFile->config->basepath ); // @phpstan-ignore argument.type
 
 		// Add any src directories.
 		$absolute_paths = PathValidationHelper::relative_to_absolute( $phpcsFile, $this->src_directory );

Yoast/Tests/Utils/PSR4PathsTraitTest.php

@@ -311,7 +311,7 @@ public function test_validate_psr4_paths_without_basepath_resets_validated() {
 		$this->assertSame( $input['expected'], $this->validated_psr4_paths, 'Validated paths has not been set correctly' );
 
 		// Now make sure that the missing basepath resets the validated paths.
-		$phpcsFile->config->basepath = null; // @phpstan-ignore assign.propertyType (Issue with the PHPCS docs. Can't be helped.)
+		$phpcsFile->config->basepath = null;
 
 		$this->validate_psr4_paths( $phpcsFile );