Implement garbage collection of `IdString`s#5417

Open

rocallahan wants to merge 19 commits intoYosysHQ:mainfrom

rocallahan:idstring-gc

Commits on Oct 21, 2025

Make IdString::begins_width/ends_with take std::string_view so we avoid a strlen when the parameter is a string constant
rocallahan
committed
Make IdString::contains take std::string_view so we avoid a strlen when the parameter is a string constant
rocallahan
committed
Store IdString lengths and use them
rocallahan
committed
Remove explicit empty-string check when looking up IdStrings
rocallahan
committed
Make RTLIL::Design::get_all_designs() unconditionally defined
rocallahan
committed
Remove YOSYS_USE_STICKY_IDS
rocallahan
committed
Create RTLIL::OwningIdString and use it in a few places
rocallahan
committed
Implement IdString garbage collection instead of refcounting.
rocallahan
committed
Make IdString refcounts a hashtable containing only the nonzero refcounts
rocallahan
committed
Remove StaticIdString and just use IdString now that we can make it constexpr
rocallahan
committed
Make new_id/new_id_suffix taking string_view to avoid allocating strings
rocallahan
committed
Ensure that `new_id(_suffix)()` cannot create collisions with existing `IdString`s.
rocallahan
committed
Make NEW_ID create IDs whose string allocation is delayed
rocallahan
committed
Optimize IdString operations to avoid calling c_str()
rocallahan
committed
Avoid calling IdString::c_str() in opt_clean
rocallahan
committed
Fix verilog backend to avoid IdString::c_str()
rocallahan
committed
Fix AbcModuleState::remap_name() to avoid calling IdString::c_str()
rocallahan
committed
Add timing stats for IdString garbage collection
rocallahan
committed
tests: remove unstable FPGA synthesis result checks

widlarizer
authored and
rocallahan
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Implement garbage collection of `IdString`s#5417

Implement garbage collection of `IdString`s#5417
rocallahan wants to merge 19 commits intoYosysHQ:mainfrom
rocallahan:idstring-gc

Commits on Oct 21, 2025

Make IdString::begins_width/ends_with take std::string_view so we avoid a strlen when the parameter is a string constant

Make IdString::contains take std::string_view so we avoid a strlen when the parameter is a string constant

Store IdString lengths and use them

Remove explicit empty-string check when looking up IdStrings

Make RTLIL::Design::get_all_designs() unconditionally defined

Remove YOSYS_USE_STICKY_IDS

Create RTLIL::OwningIdString and use it in a few places

Implement IdString garbage collection instead of refcounting.

Make IdString refcounts a hashtable containing only the nonzero refcounts

Remove StaticIdString and just use IdString now that we can make it constexpr

Make new_id/new_id_suffix taking string_view to avoid allocating strings

Ensure that `new_id(_suffix)()` cannot create collisions with existing `IdString`s.

Make NEW_ID create IDs whose string allocation is delayed

Optimize IdString operations to avoid calling c_str()

Avoid calling IdString::c_str() in opt_clean

Fix verilog backend to avoid IdString::c_str()

Fix AbcModuleState::remap_name() to avoid calling IdString::c_str()

Add timing stats for IdString garbage collection

tests: remove unstable FPGA synthesis result checks

Implement garbage collection of `IdString`s#5417rocallahan wants to merge 19 commits intoYosysHQ:mainYosysHQ/yosys:mainfrom rocallahan:idstring-gcrocallahan/yosys:idstring-gcCopy head branch name to clipboard

Commits

Commits on Oct 21, 2025

Implement garbage collection of `IdString`s#5417
rocallahan wants to merge 19 commits intoYosysHQ:mainfrom
rocallahan:idstring-gc