fix: use dumpy configurator if configCommands haven't numeric keys. remove deprecated controller.

Author: Xel4ek

app/controllers/configuration-commands.js

@@ -41,12 +41,16 @@ appController.controller('ConfigCommandsController', function ($scope, $routePar
         $element.find('.collapse').removeClass('in');
         Object.keys($scope.expanded).map(key => $scope.expanded[key] = false)
     }
+    function smartConfigEnable(configCommands) {
+        return (configCommands?.version >= 3) && !Object.keys(configCommands).some((el) => !isNaN(+el));
+    }
+
     function onInit() {
         configurationCommandsService.init($routeParams.nodeId).then(function (commands) {
             $scope.commandsUpdated = commands;
             $scope.node = configurationCommandsService.node();
             const configCommands = commands.find(({instance, ccId}) =>  ccId === 112 && instance === 0);
-            if (configCommands?.version >= 3) $scope.configCommands = configurationCommandsService.getConfigCommands($routeParams.nodeId);
+            if (smartConfigEnable(configCommands)) $scope.configCommands = configurationCommandsService.getConfigCommands($routeParams.nodeId);
             else $scope.configCommands = configCommands;
         }).catch(() => {
             $scope.alert = {

app/controllers/configuration_commands.js

@@ -108,7 +108,6 @@
     <script src="app/controllers/configuration_interview.js"></script>
     <script src="app/controllers/configuration_configuration.js"></script>
     <script src="app/controllers/configuration-commands.js"></script>
-    <script src="app/controllers/configuration_commands.js"></script>
     <script src="app/controllers/configuration_association.js"></script>
     <script src="app/controllers/configuration_firmware.js"></script>
     <script src="app/controllers/configuration_health.js"></script>