Update KSP to 2.3.5 (#434)

Author: ZacSweers

CHANGELOG.md

@@ -4,6 +4,8 @@ Changelog
 **Unreleased**
 --------------
 
+- Update to KSP `2.3.5` and remove the memory leak patch as it's now fixed upstream.
+
 0.12.1
 ------
 

gradle/libs.versions.toml

@@ -2,7 +2,7 @@
 gjf = "1.33.0"
 kotlin = "2.3.0"
 kotlinpoet = "2.2.0"
-ksp = "2.3.4"
+ksp = "2.3.5"
 ktfmt = "0.61"
 
 [plugins]

ksp/src/main/kotlin/com/tschuchort/compiletesting/Ksp2.kt

@@ -1,16 +1,12 @@
 /* Adds support for KSP (https://goo.gle/ksp). */
 package com.tschuchort.compiletesting
 
-import com.google.devtools.ksp.impl.KSPCoreEnvironment
 import com.google.devtools.ksp.impl.KotlinSymbolProcessing
 import com.google.devtools.ksp.processing.KSPJvmConfig
 import com.google.devtools.ksp.processing.SymbolProcessorProvider
 import java.io.File
 import java.io.PrintStream
 import java.util.EnumSet
-import ksp.com.intellij.openapi.application.ApplicationManager as ShadedKspApplicationManager
-import ksp.com.intellij.openapi.util.Disposer as ShadedKspDisposer
-import ksp.com.intellij.openapi.util.Disposer.dispose
 import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity
 import org.jetbrains.kotlin.compiler.plugin.ExperimentalCompilerApi
 
@@ -135,22 +131,8 @@ class Ksp2PrecursorTool : PrecursorTool, KspTool {
       }
     } finally {
       logger.reportAll()
-      clearKspLeaks()
     }
   }
-
-  /**
-   * KSP leaks its core environment because its CLI appears to be intended for single-shot use and
-   * stores stuff in ThreadLocals.
-   *
-   * The Gradle plugin doesn't seem to run into this because it runs all the tasks in an isolated
-   * classloader that dies between task runs.
-   */
-  private fun clearKspLeaks() {
-    KSPCoreEnvironment.instance_prop.remove()
-    // Doesn't _seem_ necessary but just in case, since it does appear to spin this up
-    ShadedKspApplicationManager.getApplication()?.let(ShadedKspDisposer::dispose)
-  }
 }
 
 private fun KotlinVersion.languageVersion(): String {