Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loadSrc fail with Safari Windows w/QuickTime #3

Open
timmhayes opened this issue Aug 26, 2010 · 8 comments
Open

loadSrc fail with Safari Windows w/QuickTime #3

timmhayes opened this issue Aug 26, 2010 · 8 comments

Comments

@timmhayes
Copy link

I'm not sure if I'm doing something wrong, but this seems like a bona fide bug...

I'm using loadSrc() on an audio element. All works correctly in Chrome, IE, and Firefox, but Safari fails to play the updated file. (All play the initially embedded file.)

My initial audio element looks like this:

<audio id="audio" controls="controls">
   <source src="audio/myaudio.mp3" type="audio/mpeg" />
   <source src="audio/myaudio.ogg" type="audio/ogg" />
</audio>

Runtime code looks like this:


var srces = [
      {src:"audio/somenewfile.mp3", type:"audio/mpeg"},
      {src:"audio/somenewfile.ogg", type:"audio/ogg"}
];
$("#audio").loadSrc(srces);

If I inspect the element after running this code, Chrome shows updated child elements. However Safari shows the as empty... meaning Safari wiped out the initial child elements, but did not replace them correctly.

One difference I can see during runtime occurs on line 287 if mm.full.js:
if(fixPreload.addSrces(elem, value, preloadPass)){return;}

Chrome returns false on this, but Safari returns true and drops out of the function, failing to execute what follows... which includes the code that creates the new child elements.

I'm using:
jMediaelement v1.3 (stable build)
Safari 4.0.3
QuickTime Player 7.6.5
Windows XP

Great code otherwise... thanks for putting it out there!

@timmhayes
Copy link
Author

The same code seems to work correctly on a machine with Safari 5.0/QT7.6.4

@aFarkas
Copy link
Owner

aFarkas commented Aug 28, 2010

Hi,

thanks for your bugreport. I can't really reproduce this issue. I made a demo @http://jsbin.com/uxiza3/2 . Can you please check this.

I don't have the correct version of Safari to test with. I was using Safari 4.05 and Quicktime 7.6.7.

regards
alex

@timmhayes
Copy link
Author

Alex:

Thanks for talking a look at the issue.

My testing computer doesn't have access to the internet, but I made a local copy of the resources and ran it on my server. The same thing occurred... the audio file played correctly with the default audio element, but failed when the loadSrc button was clicked.

Looking a the page with the web inspector... I can see the two source children have been wiped out, leaving the audio element empty.

Could this be a bug in Safari that was fixed in 4.0.4 or 4.0.5? Didn't find much relevant in the change histories, but they aren't that detailed.

Safari 4.0.4 changelog:
http://www.filehippo.com/download_safari/changelog/6528/

Safari 4.0.5 changes:
http://support.apple.com/kb/dl877

-Tim

@aFarkas
Copy link
Owner

aFarkas commented Aug 30, 2010

Hi Tim,

Yes, it seems, that this bug was fixed between 4.0.4 und 4.0.5. Do you know, where I can download 4.0.3?
regards
alex

@timmhayes
Copy link
Author

Alex:

You could try a site like this:
http://news.softpedia.com/news/Download-Safari-4-0-3-for-Mac-and-Windows-118988.shtml

I might be able to dig up an installer if that fails.

-Tim

@aFarkas
Copy link
Owner

aFarkas commented Sep 10, 2010

Hi Tim,

If I download the installer and install this. I get Safari 4.0.5. It would be very nice, if you could provide me with a suitable Installer.

regards
alex

@timmhayes
Copy link
Author

Alex:

It took me a while to find a copy, but I dug one up. I'll send a link to the e-mail address on your profile. Please let me know if I should send it elsewhere.

Thanks,

-Tim

@aFarkas
Copy link
Owner

aFarkas commented Sep 18, 2010

Hi Tim,

the Safari 4.0.3 you send me isn't installable. If I want to install it on my Windows 7 or on my WinXP VM says something about bad Installconfiguration/Side-by-Side Configuration.

I'm very sorry. If I can't get this reproduced, I can't fix this. Due to the fact, that this bug isn't reproducable with Safari 4.0.5 or Safari 5, it isn't very important bug to me.

regards
alex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants