Skip to content

Conversation

@VeskeR
Copy link

@VeskeR VeskeR commented Oct 11, 2024

Context

Resolves ECO-4904.
See Unified Test Suite repo for Chat at: https://github.com/ably-labs/unified-test-suite-chat.

Description

  • Describe the changes introduced in this PR
  • Provide relevant context or considerations for reviewers.
    • Such as why the changes are necessary,
      or how they affect the system.

Checklist

  • QA'd by the author.
  • Unit tests created (if applicable).
  • Integration tests created (if applicable).
  • Follow coding style guidelines found here.
  • TypeDoc updated (if applicable).
  • (Optional) Update documentation for new features.
  • Browser tests created (if applicable).
  • In repo demo app updated (if applicable).

Testing Instructions (Optional)

  • See result of the "Unified Test Suite" action on github

This is a copy of JS adapter from UTS Chat repo [1]

[1] ably-labs/unified-test-suite-chat#11
@VeskeR VeskeR requested a review from ttypic October 11, 2024 12:28
@github-actions github-actions bot temporarily deployed to staging/pull/364/typedoc October 11, 2024 12:29 Inactive
@github-actions
Copy link

github-actions bot commented Oct 11, 2024

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 94.18% (🎯 92%) 2853 / 3029
🟢 Statements 94.18% (🎯 92%) 2853 / 3029
🟢 Functions 93.39% (🎯 93%) 212 / 227
🟢 Branches 94.25% (🎯 93%) 771 / 818
File CoverageNo changed files found.
Generated in workflow #1552 for commit 16e355d by the Vitest Coverage Report Action

@github-actions github-actions bot temporarily deployed to staging/pull/364/typedoc October 11, 2024 12:35 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/364/typedoc October 11, 2024 12:53 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/364/typedoc October 11, 2024 12:54 Inactive
Copy link
Collaborator

@ttypic ttypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants