Vision os research #2050
Draft
Vision os research #2050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd the example app (at the moment new definition `TARGET_SUPPORTS_APNS` only includes iOS).
I've replaced all nimble expectations with `raiseException()` because they were ruled out explicitly by the authors from SPM builds. See nimble's "RaisesException.swift" for details.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
maratal
force-pushed
the
2045-visionOS-research
branch
from
8625763 to
c89572e
Compare
Looking into Marat's question [1] of why visionOS scheme was not being found in CI. (Easy to reproduce locally — do `git clean -fxd` and then run the fastlane command that CI tries to run.) Noticed that although the "Shared" box was checked in the visionOS scheme in the Xcode UI, there was no visionOS scheme in Ably.xcodeproj/xcshareddata/xcschemes. TODO incorporate into correct commit [1] #2045 (comment)
Collaborator
There was a problem hiding this comment.
Why are you using the name "xrOS" here? Isn't this old terminology?
Collaborator
Author
There was a problem hiding this comment.
It still called like that in the SDK - https://github.com/actions/runner-images/blob/main/images/macos/macos-13-Readme.md
maratal
force-pushed
the
2045-visionOS-research
branch
from
c1a876e to
ae0eac0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adresses #2045
Related issues #1070, #1137