-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect lies in Workers #142
Comments
The implemented language lies introduce an issue. To reproduce:
|
Thank you for catching that. I'm torn on whether or not this locale mismatch should be counted as a lie. I can see it being used for accessibility and development in which case the mismatch should be given respect. I think what I can do is remove the lie, and then remove the worker's engine locale from the stable fingerprint. If there is any switching the engine language monkey business, the score will slowly fall, but the fingerprint should remain stable with the system locale (if that is the only poison pill in workers). |
The change is now live on the dev site. It should go live this weekend or late Aug - maybe late Aug since this and recent updates will renew most fingerprints. |
@Niek EDIT: nevermind... they're both actually consistent with the engine.
(1).toLocaleString(undefined, {
style: 'currency',
currency: 'USD',
currencyDisplay: 'name',
minimumFractionDigits: 0,
maximumFractionDigits: 0
}) And, this gets the engine locale: Intl.DateTimeFormat().resolvedOptions().locale |
@abrahamjuliot looks like a Chrome bug to me. It's also unclear to me where the system locale it gathered from, in Linux setting |
Workers can be corrupt just like frames. Below is an unfinished concept showing the worker scope can be poisoned through the window scope.
Defensive mesures:
platform
to ua systemplatformVersion
to reported user agent versioncatch language lies[comment]Worker Poison
This does not work for blob URLs that are revoked. This can also support direct path scripts if we check the script location.
The text was updated successfully, but these errors were encountered: